public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: Philip Oakley <philipoakley@iee•org>, Jeff King <peff@peff•net>,
	Christian Couder <christian.couder@gmail•com>,
	git@vger•kernel.org
Subject: Re: [PATCH] disable grafts during fetch/push/bundle
Date: Thu, 06 Mar 2014 15:39:43 -0800	[thread overview]
Message-ID: <xmqqob1ivqv4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <531904E1.6010606@alum.mit.edu> (Michael Haggerty's message of "Fri, 07 Mar 2014 00:29:37 +0100")

Michael Haggerty <mhagger@alum•mit.edu> writes:

> I didn't mean to insult all Windows users in general.  I was only
> referring to the fact that since the default Windows command line is not
> a POSIX shell, even an experienced Windows user might have trouble
> figuring out how to execute a shell loop.  Putting this functionality in
> a git command or script, by contrast, would make it work universally, no
> fuss, no muss.

;-)

Be it graft or replace, I do not think we want to invite people to
use these mechansims too lightly to locally rewrite their history
willy-nilly without fixing their mistakes at the object layer with
"commit --amend", "rebase", "bfg", etc. in the longer term.  So in
that sense, adding a command to make it easy is not something I am
enthusiastic about.

On the other hand, if the user does need to use graft or replace
(perhaps to prepare for casting the fixed history in stone with
filter-branch), it would be good to help them avoid making mistakes
while doing so and tool support may be a way to do so.

So, ... I am of two minds.

  reply	other threads:[~2014-03-06 23:39 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04 17:48 [PATCH] disable grafts during fetch/push/bundle Jeff King
2014-03-04 20:52 ` Junio C Hamano
2014-03-05  0:56   ` Jeff King
2014-03-05 18:49     ` Junio C Hamano
2014-03-05 18:52       ` Jeff King
2014-03-05 19:18         ` Junio C Hamano
2014-03-05 19:28           ` Jeff King
2014-03-05 20:24             ` Junio C Hamano
2014-03-06  8:42           ` Michael Haggerty
2014-03-06  9:17             ` Christian Couder
2014-03-06 15:56             ` Jeff King
2014-03-06 16:41               ` Michael Haggerty
2014-03-06 17:48                 ` Jeff King
2014-03-06 17:49                   ` [RFC/PATCH 1/4] replace: refactor command-mode determination Jeff King
2014-03-06 17:49                   ` [RFC/PATCH 2/4] replace: use OPT_CMDMODE to handle modes Jeff King
     [not found]                     ` <CAP8UFD2c0UKT8Uyw4j9SzKGx2oLn=o7N-dtvQHPaaBtLT6ggcw@mail.gmail.com>
2014-03-06 18:48                       ` Jeff King
2014-03-06 17:49                   ` [RFC/PATCH 3/4] replace: factor object resolution out of replace_object Jeff King
2014-03-06 17:51                   ` [RFC/PATCH 4/4] replace: add --edit option Jeff King
2014-03-07  1:57                     ` Eric Sunshine
2014-03-07 17:17                       ` Jeff King
2014-03-06 19:00                   ` [PATCH] disable grafts during fetch/push/bundle Junio C Hamano
2014-03-06 19:07                     ` Jeff King
2014-03-06 23:01                   ` Philip Oakley
2014-03-06 23:29                     ` Michael Haggerty
2014-03-06 23:39                       ` Junio C Hamano [this message]
2014-03-07  7:08                         ` Christian Couder
2014-03-07 17:19                           ` Jeff King
2014-03-19 22:39                             ` Junio C Hamano
2014-03-21  0:49                               ` Jeff King
2014-03-06 23:48                       ` Philip Oakley
2014-03-04 23:36 ` Eric Sunshine
2014-03-05  0:37   ` Jeff King
2014-03-05  1:00     ` Eric Sunshine
2014-03-05  1:05       ` Jeff King
2014-03-05  1:07         ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqob1ivqv4.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=christian.couder@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=mhagger@alum$(echo .)mit.edu \
    --cc=peff@peff$(echo .)net \
    --cc=philipoakley@iee$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox