From: Junio C Hamano <gitster@pobox•com>
To: Sun He <sunheehnus@gmail•com>
Cc: git@vger•kernel.org, mhagger@alum•mit.edu
Subject: Re: [PATCH] builtin/pack-objects.c:write_pack_file() replace tmpname with pack_tmp_name in warning
Date: Fri, 28 Feb 2014 12:05:24 -0800 [thread overview]
Message-ID: <xmqqob1rt33v.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1393604774-19480-1-git-send-email-sunheehnus@gmail.com> (Sun He's message of "Sat, 1 Mar 2014 00:26:14 +0800")
Sun He <sunheehnus@gmail•com> writes:
> Signed-off-by: Sun He <sunheehnus@gmail•com>
> ---
> The tmpname is uninitialized and it should a bug
>
> Please ignore the former patches about this with wrong format.
> I am sorry to cause a jam in your inbox. ^_^
>
> In the end, I wanna thank Michael Haggerty who give me help.
If you look at "git log" output, you would notice that people write
something like
Helped-by: Michael Haggerty <mhagger@alum•mit.edu>
before your S-o-b: line for a case like this.
We can see that you are replacing tmpname with pack_tmp_name in
warning without you writing on the subject line. The commit log is
where you explain *why* that change is the right thing to do. And
that is totally lacking in this message.
> builtin/pack-objects.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index c733379..4922ce5 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -823,7 +823,7 @@ static void write_pack_file(void)
> utb.modtime = --last_mtime;
> if (utime(pack_tmp_name, &utb) < 0)
> warning("failed utime() on %s: %s",
> - tmpname, strerror(errno));
> + pack_tmp_name, strerror(errno));
> }
>
> /* Enough space for "-<sha-1>.pack"? */
next prev parent reply other threads:[~2014-02-28 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 16:26 [PATCH] builtin/pack-objects.c:write_pack_file() replace tmpname with pack_tmp_name in warning Sun He
2014-02-28 20:05 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-28 15:37 Sun He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqob1rt33v.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=sunheehnus@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox