From: Junio C Hamano <gitster@pobox•com>
To: kusmabite@gmail•com
Cc: Jeff King <peff@peff•net>, "Dale R. Worley" <worley@alum•mit.edu>,
Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>,
GIT Mailing-list <git@vger•kernel.org>
Subject: Re: [PATCH] pager: turn on "cat" optimization for DEFAULT_PAGER
Date: Wed, 20 Nov 2013 09:33:16 -0800 [thread overview]
Message-ID: <xmqqob5f6krn.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CABPQNSb6PD+oSw_LT6KaUYd8BTeN-WHJFodcuiLe=u76rFYFJw@mail.gmail.com> (Erik Faye-Lund's message of "Wed, 20 Nov 2013 18:24:45 +0100")
Erik Faye-Lund <kusmabite@gmail•com> writes:
>> ...
>> is set to empty., 2006-04-16). At that time, the line
>> directly above used:
>>
>> if (!pager)
>> pager = "less";
>>
>> as a fallback, meaning that it could not possibly trigger
>> the optimization. Later, a3d023d (Provide a build time
>> default-pager setting, 2009-10-30) turned that constant into
>> a build-time setting which could be anything, but didn't
>> loosen the "else" to let DEFAULT_PAGER use the optimization.
>>
>> Noticed-by: Dale R. Worley <worley@alum•mit.edu>
>> Suggested-by: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
>> Signed-off-by: Jeff King <peff@peff•net>
>> ---
>> pager.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/pager.c b/pager.c
>> index c1ecf65..fa19765 100644
>> --- a/pager.c
>> +++ b/pager.c
>> @@ -54,7 +54,7 @@ const char *git_pager(int stdout_is_tty)
>> pager = getenv("PAGER");
>> if (!pager)
>> pager = DEFAULT_PAGER;
>> - else if (!*pager || !strcmp(pager, "cat"))
>> + if (!*pager || !strcmp(pager, "cat"))
>
> Hmmpf. It's sometimes useful to actually pipe through cat rather than
> disabling the pager, as this changes the return-code from isatty. I
> sometimes use this for debugging-purposes. Does this patch break that?
If you have been running "GIT_PAGER=cat git whatever" and the like,
we did not pipe the output through "cat" and this has been the case
for a long time. The only thing the patch in question changed is
for those who build with
make DEFAULT_PAGER=cat
and I doubt that you have been debugging git by rebuilding it with
such a setting, so....
next prev parent reply other threads:[~2013-11-20 17:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 19:57 the pager Dale R. Worley
2013-08-27 4:38 ` Junio C Hamano
2013-08-28 18:19 ` Dale R. Worley
2013-08-28 20:26 ` Junio C Hamano
2013-08-29 15:41 ` Dale R. Worley
2013-08-29 15:55 ` Matthieu Moy
2013-09-03 2:27 ` Dale R. Worley
2013-09-03 2:57 ` Jonathan Nieder
2013-09-03 7:41 ` [PATCH] pager: turn on "cat" optimization for DEFAULT_PAGER Jeff King
2013-09-03 17:35 ` Junio C Hamano
2013-11-20 17:24 ` Erik Faye-Lund
2013-11-20 17:30 ` Jeff King
2013-11-20 17:33 ` Erik Faye-Lund
2013-11-20 17:33 ` Junio C Hamano [this message]
2013-11-20 17:34 ` Erik Faye-Lund
2013-09-03 8:16 ` the pager Jeff King
2013-09-03 2:37 ` Dale R. Worley
2013-09-03 8:01 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqob5f6krn.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=kusmabite@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=worley@alum$(echo .)mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox