Subject: Re: [PATCH] osxkeychain: define build targets in the top-level Makefile.

From: Junio C Hamano <[email-masked]>
Date: Tue, 10 Feb 2026 11:50:52 -0800

"Koji Nakamaru via GitGitGadget" <[email-masked]> writes:

>  Makefile                                | 17 +++++++
>  contrib/credential/osxkeychain/Makefile | 65 +++----------------------
>  2 files changed, 23 insertions(+), 59 deletions(-)

Nice simplification overall.

> diff --git a/contrib/credential/osxkeychain/Makefile b/contrib/credential/osxkeychain/Makefile
> index c68445b82d..ddb29f0563 100644
> --- a/contrib/credential/osxkeychain/Makefile
> +++ b/contrib/credential/osxkeychain/Makefile
> @@ -1,66 +1,13 @@
>  # The default target of this Makefile is...
>  all:: git-credential-osxkeychain
>  
> -include ../../../config.mak.uname
> --include ../../../config.mak.autogen
> --include ../../../config.mak
> +git-credential-osxkeychain:
> +	cd ../../..; make contrib/credential/osxkeychain/git-credential-osxkeychain

Let's not write "make", but stick to $(MAKE), perhaps like

	$(MAKE) -C ../../.. contrib/credential/osxkeychain/$@

> +install:
> +	cd ../../..; make install-git-credential-osxkeychain
>  
>  clean:
> -	$(RM) git-credential-osxkeychain git-credential-osxkeychain.o
> +	cd ../../..; make clean-git-credential-osxkeychain

Likewise.