From: Junio C Hamano <gitster@pobox•com>
To: Abraham Samuel Adekunle <abrahamadekunle50@gmail•com>
Cc: git@vger•kernel.org, "Patrick Steinhardt" <ps@pks•im>,
"Phillip Wood" <phillip.wood123@gmail•com>,
"SZEDER Gábor" <szeder.dev@gmail•com>,
"Christian Couder" <christian.couder@gmail•com>,
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>,
"Ben Knoble" <ben.knoble@gmail•com>
Subject: Re: [GSoC PATCH v7] add -p: show user's hunk decision when selecting hunks
Date: Sat, 10 Jan 2026 19:57:56 -0800 [thread overview]
Message-ID: <xmqqpl7grebf.fsf@gitster.g> (raw)
In-Reply-To: <aV_IGCld5T_dBxTs@Adekunles-MacBook-Air.local> (Abraham Samuel Adekunle's message of "Thu, 8 Jan 2026 16:07:04 +0100")
Abraham Samuel Adekunle <abrahamadekunle50@gmail•com> writes:
> When a user is interactively deciding which hunks to use or skip for
> staging, unstaging, stashing etc, there is no way to know the
> decision previously chosen for a hunk when navigating through the
> previous and next hunks using K/J respectively.
>
> Improve the UI to explicitly show if a user has previously decided to
> use a hunk (by pressing 'y') or skip the hunk (by pressing 'n').
> This will improve clarity when and aid the navigation process for the
> user.
>
> Reported-by: Junio C Hamano <gitster@pobox•com>
> Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail•com>
> ---
> Changes in v7:
> ==============
> - changed hunk selection state message to reduce prompt width
> - Removed redundant `file_diff->hunk_nr` in hunk->use check
> - Made the prompt mode more readable by retaining the space before choices
> - set `hunk_use_decision` to empty string if `hunk->use == UNDECIDED` to match
> the prompt mode.
The latest "was: X" does look short and sweet.
Let's wait for a few days to see if others have more input and then
mark the topic for 'next'.
Thanks.
next prev parent reply other threads:[~2026-01-11 3:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-30 15:06 [PATCH] add -p: show hunk selection state when selecting hunks Abraham Samuel Adekunle
2025-11-30 18:32 ` Junio C Hamano
2025-12-01 10:01 ` Abraham Samuel Adekunle
2026-01-01 21:04 ` [GSoC PATCH v2] add -p: show user's hunk decision " Abraham Samuel Adekunle
2026-01-01 22:54 ` Junio C Hamano
2026-01-02 7:20 ` Samuel Abraham
2026-01-02 18:51 ` [GSoC PATCH v3] " Abraham Samuel Adekunle
2026-01-04 6:03 ` Junio C Hamano
2026-01-04 10:36 ` Samuel Abraham
2026-01-04 11:02 ` [GSoC PATCH v4] " Abraham Samuel Adekunle
2026-01-05 19:35 ` SZEDER Gábor
2026-01-05 21:52 ` Samuel Abraham
2026-01-06 11:05 ` [GSoC PATCH v5] " Abraham Samuel Adekunle
2026-01-06 11:08 ` Kristoffer Haugsbakk
2026-01-06 11:46 ` Samuel Abraham
2026-01-06 12:01 ` [GSoC PATCH v6] " Abraham Samuel Adekunle
2026-01-06 16:10 ` Phillip Wood
2026-01-06 19:01 ` Ben Knoble
2026-01-07 0:13 ` Junio C Hamano
2026-01-06 22:02 ` Samuel Abraham
2026-01-06 22:19 ` Samuel Abraham
2026-01-07 8:49 ` Samuel Abraham
2026-01-08 15:07 ` [GSoC PATCH v7] " Abraham Samuel Adekunle
2026-01-11 3:57 ` Junio C Hamano [this message]
2026-01-11 11:04 ` Samuel Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpl7grebf.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=abrahamadekunle50@gmail$(echo .)com \
--cc=ben.knoble@gmail$(echo .)com \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=phillip.wood123@gmail$(echo .)com \
--cc=ps@pks$(echo .)im \
--cc=szeder.dev@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox