Subject: Re: [PATCH] ci: bump remaining outdated Actions versions

From: Junio C Hamano <[email-masked]>
Date: Sun, 11 Feb 2024 09:17:25 -0800

"Johannes Schindelin via GitGitGadget" <[email-masked]>
writes:

> From: Johannes Schindelin <[email-masked]>
>
> This avoids "Node.js 16 Actions" deprecation messages by bumping the
> following Actions' versions:
>
> - actions/upload-artifact from 3 to 4
> - actions/download-artifact from 3 to 4
> - actions/cache from 3 to 4
>
> Helped-by: Matthias Aßhauer <[email-masked]>
> Original-commits-by: dependabot[bot] <[email-masked]>
> Signed-off-by: Johannes Schindelin <[email-masked]>
> ---

>      - name: Upload failed tests' directories
>        if: failure() && env.FAILED_TEST_ARTIFACTS != '' && matrix.vector.jobname == 'linux32'
> -      uses: actions/upload-artifact@v1
> +      uses: actions/upload-artifact@v4
>        with:
>          name: failed-tests-${{matrix.vector.jobname}}
>          path: ${{env.FAILED_TEST_ARTIFACTS}}

Curious that, among all other uses of actions/upload-artifact@v3,
only this one has been using @v1, which may deserve explanation.
The proposed commit log message pretends that this never existed.

Please drop a non-standard "Original-commits-by:"  trailer, and
instead mention what you wrote under three-dash line about the
dependabot in the log message.  Perhaps something like...

	After activating automatic Dependabot updates in the
	git-for-windows/git repository, Dependabot noticed a couple
	of yet-unaddressed updates.  They avoid "Node.js 16 Actions"
	deprecation messages by bumping the following Actions'
	versions:

        - actions/upload-artifact from 1 or 3 to 4
        - actions/download-artifact from 3 to 4
        - actions/cache from 3 to 4

	Note that one actions/upload-artifact@v1 was used in one of
	the rules because ...

        Helped-by: Matthias Aßhauer <[email-masked]>
        Signed-off-by: Johannes Schindelin <[email-masked]>

Thanks.