From: Junio C Hamano <gitster@pobox•com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail•com>
Cc: git@vger•kernel.org, Emily Shaffer <emilyshaffer@google•com>,
Eric Sunshine <sunshine@sunshineco•com>,
Felipe Contreras <felipe.contreras@gmail•com>,
Taylor Blau <me@ttaylorr•com>,
Michael Strawbridge <michael.strawbridge@amd•com>,
Phillip Wood <phillip.wood123@gmail•com>
Subject: Re: [PATCH v2 5/5] hook: support a --to-stdin=<path> option
Date: Wed, 08 Feb 2023 13:22:22 -0800 [thread overview]
Message-ID: <xmqqpmajq2cx.fsf@gitster.g> (raw)
In-Reply-To: <patch-v2-5.5-b4e02f41194-20230208T191924Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Wed, 8 Feb 2023 20:21:15 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail•com> writes:
> From: Emily Shaffer <emilyshaffer@google•com>
>
> Expose the "path_to_stdin" API added in the preceding commit in the
> "git hook run" command.
>
> For now we won't be using this command interface outside of the tests,
> but exposing this functionality makes it easier to test the hook
> API. The plan is to use this to extend the "sendemail-validate"
> hook[1][2].
OK.
What does it take to tackle the obvious leftover bits of [4/5]? Use
tempfile API to allocate a temporary file, slurp the input and close
it, and then use the "path_to_stdin" feature to spawn the hook?
next prev parent reply other threads:[~2023-02-08 21:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 17:15 [PATCH 0/5] hook API: support stdin, convert post-rewrite Ævar Arnfjörð Bjarmason
2023-01-23 17:15 ` [PATCH 1/5] run-command.c: remove dead assignment in while-loop Ævar Arnfjörð Bjarmason
2023-01-23 22:48 ` Junio C Hamano
2023-01-23 17:15 ` [PATCH 2/5] run-command: allow stdin for run_processes_parallel Ævar Arnfjörð Bjarmason
2023-01-23 22:52 ` Junio C Hamano
2023-01-23 17:15 ` [PATCH 3/5] hook API: support passing stdin to hooks, convert am's 'post-rewrite' Ævar Arnfjörð Bjarmason
2023-01-23 23:10 ` Junio C Hamano
2023-01-23 23:13 ` Junio C Hamano
2023-01-23 17:15 ` [PATCH 4/5] sequencer: use the new hook API for the simpler "post-rewrite" call Ævar Arnfjörð Bjarmason
2023-01-24 14:46 ` Phillip Wood
2023-01-27 15:08 ` Phillip Wood
2023-01-23 17:15 ` [PATCH 5/5] hook: support a --to-stdin=<path> option for testing Ævar Arnfjörð Bjarmason
2023-01-24 0:55 ` Junio C Hamano
2023-01-24 0:59 ` Michael Strawbridge
2023-02-08 19:21 ` [PATCH v2 0/5] hook API: support stdin, convert post-rewrite Ævar Arnfjörð Bjarmason
2023-02-08 19:21 ` [PATCH v2 1/5] run-command.c: remove dead assignment in while-loop Ævar Arnfjörð Bjarmason
2023-02-08 21:03 ` Junio C Hamano
2023-02-08 19:21 ` [PATCH v2 2/5] run-command: allow stdin for run_processes_parallel Ævar Arnfjörð Bjarmason
2023-02-08 21:09 ` Junio C Hamano
2023-02-08 19:21 ` [PATCH v2 3/5] hook API: support passing stdin to hooks, convert am's 'post-rewrite' Ævar Arnfjörð Bjarmason
2023-02-08 21:12 ` Junio C Hamano
2023-02-08 19:21 ` [PATCH v2 4/5] sequencer: use the new hook API for the simpler "post-rewrite" call Ævar Arnfjörð Bjarmason
2023-02-08 21:17 ` Junio C Hamano
2023-02-08 19:21 ` [PATCH v2 5/5] hook: support a --to-stdin=<path> option Ævar Arnfjörð Bjarmason
2023-02-08 21:22 ` Junio C Hamano [this message]
2023-02-09 1:56 ` Ævar Arnfjörð Bjarmason
2023-02-08 21:23 ` [PATCH v2 0/5] hook API: support stdin, convert post-rewrite Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2023-02-03 12:15 Ævar Arnfjörð Bjarmason
2023-02-03 12:15 ` [PATCH v2 5/5] hook: support a --to-stdin=<path> option Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmajq2cx.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=emilyshaffer@google$(echo .)com \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=me@ttaylorr$(echo .)com \
--cc=michael.strawbridge@amd$(echo .)com \
--cc=phillip.wood123@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox