Subject: Re: [PATCH v4 1/2] sequencer: don't use die_errno() on refs_resolve_ref_unsafe() failure

From: Junio C Hamano <[email-masked]>
Date: Wed, 26 Jan 2022 15:57:30 -0800

Ævar Arnfjörð Bjarmason  <[email-masked]> writes:

> Change code that was faithfully migrated to the new "resolve_errno"
> API in ed90f04155d (refs API: make resolve_ref_unsafe() not set errno,
> 2021-10-16) to stop caring about the errno at all.
>
> When we fail to resolve "HEAD" after the sequencer runs it doesn't
> really help to say what the "errno" value is, since the fake backend
> errno may or may not reflect anything real about the state of the
> ".git/HEAD".

OK.  Assuming that the eventual goal is to drop the return value
parameter from the resolve_ref_unsafe() function (because according
to this caller, it is not yielding any meaningful value), this
change makes perfect sense.

> With the upcoming reftable backend this fakery will
> become even more pronounced.

This too.

Nicely explained and executed.

Thanks.