public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Jeff Hostetler <git@jeffhostetler•com>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail•com>,
	git@vger•kernel.org, jeffhost@microsoft•com
Subject: Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic
Date: Mon, 09 Aug 2021 09:49:05 -0700	[thread overview]
Message-ID: <xmqqpmumftry.fsf@gitster.g> (raw)
In-Reply-To: <42dce285-9599-4c7c-d351-44c1e338337e@jeffhostetler.com> (Jeff Hostetler's message of "Mon, 9 Aug 2021 10:34:38 -0400")

Jeff Hostetler <git@jeffhostetler•com> writes:

> On 8/9/21 2:30 AM, Carlo Marcelo Arenas Belón wrote:
>> seen with both clang 12 and gcc 11 in seen (including jh/builtin-fsmonitor)
>> as of a5a42b9f76 (from Jul 1)
>> it should be squashed into the corresponding patch from the series
>> as shown
>> in the subject and reroll IMHO; notice Junio also has some bandaid sparse
>> fixes for t/helper/test-touch.c that should be included.
>> a similar additional fix for C89 compatibility to be send as a reply
>> later
>> Carlo Marcelo Arenas Belón (2):
>>    fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon
>>    fixup! fsmonitor--daemon: implement handle_client callback
>>   builtin/fsmonitor--daemon.c | 2 +-
>>   fsmonitor-ipc.h             | 2 ++
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>> 
>
> Thanks!

Thanks, both.  

Jeff, I understand that this is planned to be rerolled post release,
so I'll not touch these fixups and let yuou worry about them ;-)

next prev parent reply	other threads:[~2021-08-09 16:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09  6:30 [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic Carlo Marcelo Arenas Belón
2021-08-09  6:30 ` [PATCH 1/2] fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon Carlo Marcelo Arenas Belón
2021-08-09  6:30 ` [PATCH 2/2] fixup! fsmonitor--daemon: implement handle_client callback Carlo Marcelo Arenas Belón
2021-08-09  7:25 ` [PATCH] test-path-utils: use a C89 compatible format for double printf Carlo Marcelo Arenas Belón
2021-08-09 14:34 ` [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic Jeff Hostetler
2021-08-09 16:49   ` Junio C Hamano [this message]
2021-08-10  5:49     ` Carlo Arenas
2021-08-10 13:52       ` Jeff Hostetler
2021-08-10 13:41     ` Jeff Hostetler
2021-08-27  5:37       ` Junio C Hamano
2021-08-27  6:04         ` Carlo Arenas
2021-08-27 17:11           ` Junio C Hamano
2021-08-28  9:45             ` Carlo Arenas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpmumftry.fsf@gitster.g \
    --to=gitster@pobox$(echo .)com \
    --cc=carenas@gmail$(echo .)com \
    --cc=git@jeffhostetler$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jeffhost@microsoft$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox