Subject: Re: [PATCH] Move format-patch base commit and prerequisites before email signature

From: Junio C Hamano <[email-masked]>
Date: Fri, 09 Sep 2016 13:51:04 -0700

Josh Triplett <[email-masked]> writes:

> On Fri, Sep 09, 2016 at 12:41:56PM -0700, Junio C Hamano wrote:
>> So here is a suggested replacement.  I notice that in the MIME case,
>> we do not leave any blank line between the last line of the patch
>> and the baseinfo, which makes it look a bit strange, e.g. output of
>> "format-patch --attach=mimemime -1" may end like this:
>> 
>>     +       test_write_lines 1 2 >expect &&
>>     +       test_cmp expect actual
>>     +'
>>     +
>>      test_expect_success 'format-patch --pretty=mboxrd' '
>>             sp=" " &&
>>             cat >msg <<-INPUT_END &&
>>     base-commit: 6ebdac1bab966b720d776aa43ca188fe378b1f4b
>> 
>>     --------------mimemime--
>> 
>> We may want to tweak it a bit further.
>>  ...
>
> Looks good to me.

Thanks.

Do you mean that the base information that appears immediately after
the patch text (either for MIME case or plain-text) does not bother
you, though?