From: Junio C Hamano <gitster@pobox•com>
To: Elia Pinto <gitter.spiros@gmail•com>
Cc: git@vger•kernel.org, tboegi@web•de, ramsay@ramsayjones•plus.com,
sunshine@sunshineco•com, peff@peff•net
Subject: Re: [PATCH 4/4] imap-send.c: introduce the GIT_TRACE_CURL enviroment variable
Date: Tue, 19 Apr 2016 11:05:14 -0700 [thread overview]
Message-ID: <xmqqpotl1nl1.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160419151044.27814-5-gitter.spiros@gmail.com> (Elia Pinto's message of "Tue, 19 Apr 2016 15:10:44 +0000")
Elia Pinto <gitter.spiros@gmail•com> writes:
> Permit the use of the GIT_TRACE_CURL environment variable calling
> the curl_trace and curl_dump http.c helper routine
s/$/./; the patch itself is very concise and the "dump" thing in 3/4
looked sensible.
>
> Helped-by: Torsten Bögershausen <tboegi@web•de>
> Helped-by: Ramsay Jones <ramsay@ramsayjones•plus.com>
> Helped-by: Junio C Hamano <gitster@pobox•com>
> Helped-by: Eric Sunshine <sunshine@sunshineco•com>
> Helped-by: Jeff King <peff@peff•net>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail•com>
> ---
> imap-send.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/imap-send.c b/imap-send.c
> index 938c691..b371a78 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1444,6 +1444,12 @@ static CURL *setup_curl(struct imap_server_conf *srvc)
> if (0 < verbosity || getenv("GIT_CURL_VERBOSE"))
> curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
>
> + if (trace_want(&trace_curl)) {
> + curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
> + curl_easy_setopt(curl, CURLOPT_DEBUGFUNCTION, curl_trace);
> + curl_easy_setopt(curl, CURLOPT_DEBUGDATA, NULL);
> + }
> +
> return curl;
> }
prev parent reply other threads:[~2016-04-19 18:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 15:10 [PATCHv2 0/4] Implements the GIT_TRACE_CURL environment variable Elia Pinto
2016-04-19 15:10 ` [PATCH 1/4] http.h: Add debug callback and helper routine for implementing the GIT_TRACE_CURL environment variable in http.c Elia Pinto
2016-04-19 18:00 ` Junio C Hamano
2016-04-19 21:48 ` Ramsay Jones
2016-04-19 22:11 ` Ramsay Jones
2016-04-19 15:10 ` [PATCH 2/4] http.c: implements the GIT_TRACE_CURL environment variable Elia Pinto
2016-04-19 18:03 ` Junio C Hamano
2016-04-19 20:24 ` Junio C Hamano
2016-04-19 15:10 ` [PATCH 3/4] git.txt: document the new " Elia Pinto
2016-04-19 15:10 ` [PATCH 4/4] imap-send.c: introduce the GIT_TRACE_CURL enviroment variable Elia Pinto
2016-04-19 18:05 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpotl1nl1.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitter.spiros@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=ramsay@ramsayjones$(echo .)plus.com \
--cc=sunshine@sunshineco$(echo .)com \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox