public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Stanislav Kolotinskiy <stanislav@assembla•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] git-send-pack: Fix --all option when used with directory
Date: Thu, 24 Mar 2016 09:11:27 -0700	[thread overview]
Message-ID: <xmqqpoujama8.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1458750262-25765-1-git-send-email-stanislav@assembla.com> (Stanislav Kolotinskiy's message of "Wed, 23 Mar 2016 18:24:22 +0200")

Stanislav Kolotinskiy <stanislav@assembla•com> writes:

> Subject: Re: [PATCH] git-send-pack: Fix --all option when used with directory

Please see "git shortlog --no-merges" output from recent history and
notice that s/Fix/fix/ would make things more consistent.

> When using git send-pack with --all option and a target directory,
> usage message is being displayed instead of performing the actual
> transmission.
>
> The reason for this issue is that refspecs variable is being
> calculated in a different way comparing to previous versions, and
> even though the number of refspecs (nr_refspecs) is 0, refspecs
> contain all the arguments and switches passed to send-pack.

Thanks for noticing; the above explanation however does not make it
very clear why the symptom exhibits itself only when "directory" is
given (it also is unclear if "target" being a directory is special,
or if any remote repository specification, e.g. host:/path/to/dir,
triggers the same problem).

next prev parent reply	other threads:[~2016-03-24 16:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 16:24 [PATCH] git-send-pack: Fix --all option when used with directory Stanislav Kolotinskiy
2016-03-23 21:22 ` Jeff King
2016-03-23 21:30   ` Jeff King
2016-03-24 13:57   ` Stanislav Kolotinskiy
2016-03-24 17:37     ` Jeff King
2016-03-24 17:49       ` Stanislav Kolotinskiy
2016-03-24 16:11 ` Junio C Hamano [this message]
2016-03-24 17:47   ` Stanislav Kolotinskiy
2016-03-24 18:02     ` Jeff King
2016-04-01 10:42       ` Stanislav Kolotinskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpoujama8.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=stanislav@assembla$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox