From: Junio C Hamano <gitster@pobox•com>
To: Duy Nguyen <pclouds@gmail•com>
Cc: Stephen Smith <ischis2@cox•net>, Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH v2 2/2] object name: introduce '^{/!-<negativepattern>}' notation
Date: Mon, 11 Jan 2016 09:13:33 -0800 [thread overview]
Message-ID: <xmqqpox8xcn6.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACsJy8Dar9sCkTg_SQsDUOWYNQ1PHjmA0KcgrvpvmeY=yVXPMg@mail.gmail.com> (Duy Nguyen's message of "Sat, 9 Jan 2016 09:18:11 +0700")
Duy Nguyen <pclouds@gmail•com> writes:
> On Fri, Jan 8, 2016 at 1:04 PM, Stephen Smith <ischis2@cox•net> wrote:
>>> > +test_expect_success 'ref^{/!-}' '
>>> > + test_must_fail git rev-parse master^{/!-}
>>> > +'
>
> Shouldn't it be ^{!/... instead of ^{/!... ? People could have a
> pattern starting with "!" and /! will change its meaning. On the other
> hand, anything else after { is still reserved and can safely be used.
http://thread.gmane.org/gmane.comp.version-control.git/40460/focus=40477
clarifies the above, I think.
Back then we seem to have been thinking only about ":" as the
overall "search the history to name an object traversing from all
tips" prefix, but the current one is described in terms of the more
generally useful "<committish>^{/<pattern>}" syntax and the escape
hatch applies--they are both handled by get_sha1_oneline() the same
way.
prev parent reply other threads:[~2016-01-11 17:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 0:24 [PATCH v2 0/2] specify commit by negative pattern Will Palmer
2015-06-06 0:24 ` [PATCH v2 1/2] test for '!' handling in rev-parse's named commits Will Palmer
2015-06-06 0:24 ` [PATCH v2 2/2] object name: introduce '^{/!-<negative pattern>}' notation Will Palmer
2015-06-08 16:39 ` Junio C Hamano
2015-06-09 18:14 ` Will Palmer
2015-10-28 17:52 ` Junio C Hamano
2016-01-08 6:04 ` [PATCH v2 2/2] object name: introduce '^{/!-<negativepattern>}' notation Stephen Smith
2016-01-08 18:21 ` Junio C Hamano
2016-01-10 2:20 ` [PATCH V3 0/2] specify commit by negative pattern Stephen P. Smith
2016-01-10 2:22 ` [PATCH V3 1/2] test for '!' handling in rev-parse's named commits Stephen P. Smith
2016-01-10 2:23 ` [PATCH V3 2/2] object name: introduce '^{/!-<negative pattern>}' notation Stephen P. Smith
2016-01-11 18:10 ` Philip Oakley
2016-01-13 4:51 ` [PATCH V4 0/2] specify commit by negative pattern Stephen P. Smith
2016-01-13 4:51 ` [PATCH V4 1/2] test for '!' handling in rev-parse's named commits Stephen P. Smith
2016-01-13 4:52 ` [PATCH V4 2/2] object name: introduce '^{/!-<negative pattern>}' notation Stephen P. Smith
2016-01-13 19:15 ` Junio C Hamano
2016-01-31 0:06 ` [PATCH V5 " Stephen P. Smith
2016-02-01 21:42 ` Junio C Hamano
2016-01-10 13:25 ` [PATCH V3 0/2] specify commit by negative pattern Philip Oakley
2016-01-11 0:08 ` Stephen P. Smith
2016-01-11 18:04 ` Philip Oakley
2016-01-10 14:14 ` Stephen & Linda Smith
2016-01-10 23:36 ` Philip Oakley
2016-01-09 1:55 ` [PATCH v2 2/2] object name: introduce '^{/!-<negativepattern>}' notation Stephen & Linda Smith
2016-01-09 2:18 ` Duy Nguyen
2016-01-11 17:13 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpox8xcn6.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=ischis2@cox$(echo .)net \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox