From: Junio C Hamano <gitster@pobox•com>
To: Christian Couder <christian.couder@gmail•com>
Cc: git <git@vger•kernel.org>, "Jeff King" <peff@peff•net>,
"Ævar Arnfjörð" <avarab@gmail•com>,
"Nguyen Thai Ngoc Duy" <pclouds@gmail•com>,
"David Turner" <dturner@twopensource•com>,
"Eric Sunshine" <sunshine@sunshineco•com>,
"Torsten Bögershausen" <tboegi@web•de>,
"Christian Couder" <chriscool@tuxfamily•org>
Subject: Re: [PATCH v4 09/10] config: add core.untrackedCache
Date: Fri, 08 Jan 2016 11:43:24 -0800 [thread overview]
Message-ID: <xmqqpoxb26xv.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAP8UFD2eJjR4QxtE0x8BbKOAGwi4cwERG7bF89apPbJye356AQ@mail.gmail.com> (Christian Couder's message of "Fri, 8 Jan 2016 18:52:31 +0100")
Christian Couder <christian.couder@gmail•com> writes:
> I just tried Duy's approach by moving into read_index_from() the code
> I had put in wt_status_collect_untracked() and it doesn't work because
> "git status" calls read_index_from() before calling
> git_default_core_config().
I didn't expect to (and didn't want to) see the configuration be
dead by git_default_core_config() in the first place, though.
I instead was expecting that it would be done through the caching
layer, e.g. by calling git_config_get_maybe_bool() interface when
read_index_from() wants to see if it needs to muck with the existing
(or missing) extension.
next prev parent reply other threads:[~2016-01-08 19:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 7:09 [PATCH v4 00/10] Untracked cache improvements Christian Couder
2015-12-29 7:09 ` [PATCH v4 01/10] dir: free untracked cache when removing it Christian Couder
2015-12-29 22:26 ` Junio C Hamano
2015-12-29 7:09 ` [PATCH v4 02/10] update-index: use enum for untracked cache options Christian Couder
2015-12-29 7:09 ` [PATCH v4 03/10] update-index: add --test-untracked-cache Christian Couder
2015-12-29 22:28 ` Junio C Hamano
2015-12-29 7:09 ` [PATCH v4 04/10] update-index: add untracked cache notifications Christian Couder
2015-12-29 7:09 ` [PATCH v4 05/10] update-index: move 'uc' var declaration Christian Couder
2015-12-29 7:09 ` [PATCH v4 06/10] dir: add {new,add}_untracked_cache() Christian Couder
2015-12-29 7:09 ` [PATCH v4 07/10] dir: add remove_untracked_cache() Christian Couder
2015-12-29 7:09 ` [PATCH v4 08/10] dir: simplify untracked cache "ident" field Christian Couder
2015-12-29 22:32 ` Junio C Hamano
2015-12-30 22:01 ` Christian Couder
2015-12-30 11:47 ` Torsten Bögershausen
2015-12-30 17:20 ` Christian Couder
2015-12-29 7:09 ` [PATCH v4 09/10] config: add core.untrackedCache Christian Couder
2015-12-29 22:35 ` Junio C Hamano
2015-12-30 22:47 ` Christian Couder
2015-12-30 23:23 ` Junio C Hamano
2015-12-31 12:33 ` Christian Couder
2016-01-04 18:09 ` Junio C Hamano
2016-01-08 17:52 ` Christian Couder
2016-01-08 19:43 ` Junio C Hamano [this message]
2015-12-29 7:09 ` [PATCH v4 10/10] t7063: add tests for core.untrackedCache Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpoxb26xv.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=christian.couder@gmail$(echo .)com \
--cc=dturner@twopensource$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sunshine@sunshineco$(echo .)com \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox