From: Junio C Hamano <gitster@pobox•com>
To: Julian Andres Klode <jak@debian•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] hooks/update: Add a hooks.denyunsignedtags option
Date: Mon, 21 Dec 2015 10:52:00 -0800 [thread overview]
Message-ID: <xmqqpoxzfxdb.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqq37uvhdpw.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Mon, 21 Dec 2015 10:13:31 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> Use of "cat-file -p" is a bad manner in scripts, as we reserve the
> right to change what "-p" output looks like purely on human
> usability. "cat-file tag", perhaps?
>
> Also,
>
> $ git grep ' PGP '
>
> in our source tells me that we use a bit tighter pattern even when
> we are casually trying to see if the thing looks like a PGP signed
> payload.
>
> if test "$allowunsigned" = "true" ||
> git cat-file "$newrev" |
> grep -q '^-----BEGIN PGP SIGNATURE-----$'
> then
> ...
>
> or something?
I think an intelligent reader would have understood what I meant,
but the 'cat-file' in the above needs to say what type of thing
it is asking to dump, i.e.
if test "$allowunsigned" = "true" ||
git cat-file tag "$newrev" |
grep -q '^-----BEGIN PGP SIGNATURE-----$'
then
Sorry for the noise.
next prev parent reply other threads:[~2015-12-21 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 17:32 [PATCH] hooks/update: Add a hooks.denyunsignedtags option Julian Andres Klode
2015-12-21 18:13 ` Junio C Hamano
2015-12-21 18:52 ` Junio C Hamano [this message]
2015-12-21 19:29 ` Eric Sunshine
-- strict thread matches above, loose matches on Subject: below --
2015-09-12 10:37 Julian Andres Klode
2015-09-12 10:40 ` Julian Andres Klode
2015-09-22 18:42 ` Julian Andres Klode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpoxzfxdb.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jak@debian$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox