public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Michael J Gruber <git@drmicha•warpmail.net>
Cc: James McCoy <vega.james@gmail•com>,
	git@vger•kernel.org, Jeff King <peff@peff•net>
Subject: Re: [PATCH v2] filter-branch: remove multi-line headers in msg filter
Date: Fri, 09 Oct 2015 10:53:28 -0700	[thread overview]
Message-ID: <xmqqpp0oormv.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <561767AC.6060503@drmicha.warpmail.net> (Michael J. Gruber's message of "Fri, 9 Oct 2015 09:07:24 +0200")

Michael J Gruber <git@drmicha•warpmail.net> writes:

>> Set IFS to an empty string for the “read” call, thus disabling the word
>> splitting, which causes $header_line to be set to the non-empty value '
>> '.  This allows the loop to fully consume the header lines before
>> emitting the original, intact commit message.
>> 
>> Signed-off-by: James McCoy <vega.james@gmail•com>
>> ---
>
> Thanks for hanging in :)
>
> Reviewed-by: Michael J Gruber <git@drmicha•warpmail.net>

As long as you are fine with giving authorship to James, I am fine
with that.  I'll amend what is queued with your reviewed-by above
and will merge to 'next'.

Thanks.

next prev parent reply	other threads:[~2015-10-09 17:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09  0:21 [PATCH v2] filter-branch: remove multi-line headers in msg filter James McCoy
2015-10-09  7:07 ` Michael J Gruber
2015-10-09 17:53   ` Junio C Hamano [this message]
2015-10-12  7:26     ` Michael J Gruber
2015-10-12 16:05       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpp0oormv.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@drmicha$(echo .)warpmail.net \
    --cc=git@vger$(echo .)kernel.org \
    --cc=peff@peff$(echo .)net \
    --cc=vega.james@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox