Subject: Re: [PATCH 10/67] mailsplit: make PATH_MAX buffers dynamic

From: Junio C Hamano <[email-masked]>
Date: Wed, 16 Sep 2015 11:13:37 -0700

Jeff King <[email-masked]> writes:

> +		free(file);
> +		file = xstrfmt("%s/%s", maildir, list.items[i].string);

Repeated pattern makes one wonder if a thin wrapper

	xstrfmt_to(&file, "%s/%s", maildir, list.items[i].string);

that first frees the existing value and then overwrites is an
overall win.  Perhaps not, as you would (1) initialize the variable
to NULL before doing a series of xstrfmt_to(), and (2) free the final
one yourself.