From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: "Tanay Abhra" <tanayabh@gmail•com>,
"Bjørnar Snoksrud" <snoksrud@gmail•com>,
"Git Mailing List" <git@vger•kernel.org>
Subject: Re: Minor bug with help.autocorrect.
Date: Sun, 23 Aug 2015 23:36:21 -0700 [thread overview]
Message-ID: <xmqqpp2d5h22.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150824054327.GB14403@sigill.intra.peff.net> (Jeff King's message of "Mon, 24 Aug 2015 01:43:27 -0400")
Jeff King <peff@peff•net> writes:
> Yeah, I agree these are the only two sane fixes. Plumbing the quiet flag
> through does seem really invasive; every "git_config_get_foo" variant
> would have to learn it. Probably it's too gross to have a global like:
>
> config_lax_mode = 1;
> git_config_get_string(key.buf, &v);
> config_lax_mode = 0;
>
> That makes a nice tidy patch, but I have a feeling we would regret it
> later. :)
Yeah, I do think the double-checking the patch in your follow-up
does is not so bad. Thanks for following it through (now I must
remember not to drop these patches ;-).
prev parent reply other threads:[~2015-08-24 6:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 10:35 Minor bug with help.autocorrect Bjørnar Snoksrud
2015-08-21 16:10 ` Junio C Hamano
2015-08-21 16:23 ` Jeff King
2015-08-21 22:13 ` Junio C Hamano
2015-08-24 5:43 ` Jeff King
2015-08-24 6:11 ` Jeff King
2015-08-24 6:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpp2d5h22.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=snoksrud@gmail$(echo .)com \
--cc=tanayabh@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox