Subject: Re: [PATCH] rebase: return non-zero error code if format-patch fails

From: Junio C Hamano <[email-masked]>
Date: Fri, 03 Jul 2015 10:52:32 -0700

Clemens Buchacher <[email-masked]> writes:

> Since e481af06 (rebase: Handle cases where format-patch fails) we
> notice if format-patch fails and return immediately from
> git-rebase--am. We save the return value with ret=$?, but then we
> return $?, which is usually zero in this case.
>
> Fix this by returning $ret instead.

Sounds sensible.

>
> Cc: Andrew Wong <[email-masked]>
> Signed-off-by: Clemens Buchacher <[email-masked]>
> Reviewed-by: Jorge Nunes <[email-masked]>

Where was this review made?  I may have missed a recent discussion,
and that is why I am asking, because Reviewed-by: lines that cannot
be validated by going back to the list archive does not add much
value.

Thanks.

> ---
>  git-rebase--am.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-rebase--am.sh b/git-rebase--am.sh
> index f923732..9ae898b 100644
> --- a/git-rebase--am.sh
> +++ b/git-rebase--am.sh
> @@ -78,7 +78,7 @@ else
>  
>  		As a result, git cannot rebase them.
>  		EOF
> -		return $?
> +		return $ret
>  	fi
>  
>  	git am $git_am_opt --rebasing --resolvemsg="$resolvemsg" \