From: Junio C Hamano <gitster@pobox•com>
To: Andreas Schwab <schwab@linux-m68k•org>
Cc: Karthik Nayak <karthik.188@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH v3] git: make "git -C '' <cmd>" not to barf
Date: Fri, 06 Mar 2015 10:31:21 -0800 [thread overview]
Message-ID: <xmqqpp8myo3q.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <87d24mnmon.fsf@igel.home> (Andreas Schwab's message of "Fri, 06 Mar 2015 16:57:28 +0100")
Andreas Schwab <schwab@linux-m68k•org> writes:
> Karthik Nayak <karthik.188@gmail•com> writes:
>
>> + if (*((*argv)[1]) == 0)
>
> IMHO (*argv)[1][0] is easier to understand.
Thanks for saying that. I had to scratch my head every time I had
to see this change from various people ;-)
prev parent reply other threads:[~2015-03-06 18:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 7:05 [PATCH v3] git: make "git -C '' <cmd>" not to barf Karthik Nayak
2015-03-06 8:53 ` Eric Sunshine
2015-03-06 10:53 ` karthik nayak
2015-03-06 15:57 ` Andreas Schwab
2015-03-06 18:31 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpp8myo3q.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=karthik.188@gmail$(echo .)com \
--cc=schwab@linux-m68k$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox