public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: git@vger•kernel.org
Cc: Scott Schmit <i.grok@comcast•net>,
	Alexander Kuleshov <kuleshovmail@gmail•com>
Subject: Re: [PATCH] stash: git stash create and git stash store added to git stash usage synopsys
Date: Thu, 12 Feb 2015 14:54:58 -0800	[thread overview]
Message-ID: <xmqqpp9epwot.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqy4p59s1q.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Wed, 14 Jan 2015 09:43:29 -0800")

Junio C Hamano <gitster@pobox•com> writes:

> Scott Schmit <i.grok@comcast•net> writes:
>>
>> Considering the man page says create & store are intended for scripts
>> and "probably not the command you want to use", why would we want it in
>> the synopsis?
>
> With the understanding that these are only for scripters, I think we
> can agree that we do want to describe them in the manual pages, and
> we do not want them in the completion.
>
> I feel "git stash -h" output is on the borderline, and can be argued
> both ways:
>
>  - When you script and are not clear how a command you wanted to use
>    in your script is to be used, it wouldn't be a crime to ask the
>    short "git stash -h" form (instead of the full manual page "git
>    stash --help") to remind how the command line ought to be
>    spelled.
>
>  - When you are not interested in script at all, from the command
>    line you may want to be reminded how to spell the subcommand with
>    "git stash -h" form.  Having "store" listed, which will never be
>    what you want in this scenario, will be confusing.  You want to
>    see "save".
>
> So, I dunno.

As I haven't heard anything after this, I am inclined to drop this
topic that has been sitting on my Undecided pile.

    * ak/stash-store-create-help (2015-01-13) 1 commit
     - stash: show "create" and "store" subcommands in usage-help

     Undecided.

Please speak up if somebody new feels strongly otherwise [*1*].

Thanks.


[Footnote]

*1* I already know Scott Schmit was against it, and Alexander
Kuleshov as the original author was for it ;-)

      reply	other threads:[~2015-02-12 22:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 17:54 [PATCH] stash: git stash create and git stash store added to git stash usage synopsys Alexander Kuleshov
2015-01-14  3:11 ` Scott Schmit
2015-01-14 17:43   ` Junio C Hamano
2015-02-12 22:54     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpp9epwot.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=i.grok@comcast$(echo .)net \
    --cc=kuleshovmail@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox