public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Michael Blume <blume.mike@gmail•com>
Cc: Git List <git@vger•kernel.org>, EungJun Yi <semtlenori@gmail•com>
Subject: Re: Accept-language test fails on Mac OS
Date: Fri, 05 Dec 2014 14:51:37 -0800	[thread overview]
Message-ID: <xmqqppbxogli.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAO2U3QgoSmYkDYbvFnChxPMrTCEboUbk1NWjv+9Us60EfozN_w@mail.gmail.com> (Michael Blume's message of "Fri, 5 Dec 2014 14:35:51 -0800")

Michael Blume <blume.mike@gmail•com> writes:

> Test #25 'git client sends Accept-Language based on LANGUAGE, LC_ALL,
> LC_MESSAGES and LANG' in t5550 fails consistently on my mac, and has
> since the test was introduced. Test 26 and 27 ('git client sends
> Accept-Language with many preferred languages' and 'git client does
> not send Accept-Language') seem fine.
>
> I'm building git with NO_GETTEXT=1, which may be an issue? But in that
> case the test should probably be gated on gettext?

I recall queuing a SQUASH??? on top of the posted patch; does these
tests pass with it reverted?

  reply	other threads:[~2014-12-05 22:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 22:35 Accept-language test fails on Mac OS Michael Blume
2014-12-05 22:51 ` Junio C Hamano [this message]
2014-12-05 23:01   ` Michael Blume
2014-12-06  9:50     ` Torsten Bögershausen
2014-12-06 19:44       ` Yi, EungJun
2014-12-06 21:04         ` Torsten Bögershausen
2014-12-07  6:54           ` Yi, EungJun
2014-12-07  9:56             ` Torsten Bögershausen
2014-12-07  7:18           ` Jeff King
2014-12-07 10:03             ` Torsten Bögershausen
2014-12-08 15:51             ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqppbxogli.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=blume.mike@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=semtlenori@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox