From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH/RFC] rerere: error out on autoupdate failure
Date: Wed, 03 Dec 2014 09:41:32 -0800 [thread overview]
Message-ID: <xmqqppc0iqb7.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqy4qoiqmu.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Wed, 03 Dec 2014 09:34:33 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> Instead of crafting a new message, why not just stop passing IGNORE_ERRORS
> and have add_file_to_cache() report the failure? That is:
>
> if (add_file_to_cache(item->string, 0))
> return -1;
Err, that should be exit(128) to mimic die().
> That way, the user will get more useful diagnosis because there are
> different reasons why an "add" may fail and we give different error
> messages to them.
next prev parent reply other threads:[~2014-12-03 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 4:20 [PATCH/RFC] rerere: error out on autoupdate failure Jonathan Nieder
2014-12-03 17:34 ` Junio C Hamano
2014-12-03 17:41 ` Junio C Hamano [this message]
2014-12-03 18:52 ` [PATCH v2] " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqppc0iqb7.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox