public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: "Frédéric Brière" <fbriere@fbriere•net>,
	git@vger•kernel.org, "Jeff King" <peff@peff•net>
Subject: Re: $GIT_CONFIG should either apply to all commands, or none at all
Date: Thu, 02 Oct 2014 10:51:05 -0700	[thread overview]
Message-ID: <xmqqppeanywm.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141002011546.GR1175@google.com> (Jonathan Nieder's message of "Wed, 1 Oct 2014 18:15:46 -0700")

Jonathan Nieder <jrnieder@gmail•com> writes:

> Yep.  One possibility would be to do something like the following (A):
>
>  1) advertise in the git-config(1) manpage that the GIT_CONFIG
>     environment variable only affects the behavior of the 'git config'
>     command
>
>  2) introduce an environment variable GIT_I_AM_PORCELAIN.  (If doing
>     this, we could come up with a better name, but this is just an
>     illustration.)  Set and export that envvar in git-sh-setup.sh.
>     When that environment variable is set, make git-config stop paying
>     attention to GIT_CONFIG.
>
>     That way, git commands that happen to be scripts would not be
>     affected by the GIT_CONFIG setting any more.

At the places you plan to update porcelains to set and export
GIT_I_AM_PORCELAIN, you could unset GIT_CONFIG if set.  Would that
achieve the same goal?

And you can stop there without doing 3 or 4, no?

      parent reply	other threads:[~2014-10-02 17:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20141002001034.24160.11848.reportbug@fabul.fbriere.net>
2014-10-02  1:15 ` $GIT_CONFIG should either apply to all commands, or none at all Jonathan Nieder
2014-10-02 15:59   ` Jeff King
2014-10-02 17:51   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqppeanywm.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=fbriere@fbriere$(echo .)net \
    --cc=git@vger$(echo .)kernel.org \
    --cc=jrnieder@gmail$(echo .)com \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox