From: Junio C Hamano <gitster@pobox•com>
To: Stepan Kasal <kasal@ucw•cz>
Cc: GIT Mailing-list <git@vger•kernel.org>,
Erik Faye-Lund <kusmabite@gmail•com>,
msysGit <msysgit@googlegroups•com>,
Cezary Zawadka <czawadka@gmail•com>,
Eric Sunshine <sunshine@sunshineco•com>
Subject: Re: [PATCH] Windows: Allow using UNC path for git repository
Date: Tue, 20 May 2014 12:33:19 -0700 [thread overview]
Message-ID: <xmqqppj8xn28.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140520192132.GA7355@camelia.ucw.cz> (Stepan Kasal's message of "Tue, 20 May 2014 21:21:32 +0200")
Stepan Kasal <kasal@ucw•cz> writes:
> Hello,
>
> On Tue, May 20, 2014 at 11:57:56AM -0700, Junio C Hamano wrote:
>> It would be nice if somebody in the S-o-b chain can double-check
>> that the "combined" version is sane. [...]
>
> "Combined" was an unfortunate word. There was a pair of successive
> commits in msysgit all the time. I just decided to submit them
> squashed together. I haven't changed the code, just created a new
> commit message.
>
> That said, reviewing the function is always useful, of course.
I did mis-read your message. As the patch shows the current state
that exists in msysgit that people are happy about, the function has
already been reviewed by stakeholders, and I would be happy to apply
it.
Thanks.
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups•com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups•com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups•com.
For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2014-05-20 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 13:23 [PATCH] Windows: Allow using UNC path for git repository Stepan Kasal
2014-05-20 18:57 ` Junio C Hamano
2014-05-20 19:21 ` Stepan Kasal
2014-05-20 19:33 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqppj8xn28.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=czawadka@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kasal@ucw$(echo .)cz \
--cc=kusmabite@gmail$(echo .)com \
--cc=msysgit@googlegroups$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox