From: Junio C Hamano <gitster@pobox•com>
To: "Michael S. Tsirkin" <mst@redhat•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v4 2/2] test/send-email: to-cover, cc-cover tests
Date: Tue, 29 Apr 2014 12:01:10 -0700 [thread overview]
Message-ID: <xmqqppk0j6yx.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1398750059-11955-2-git-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Tue, 29 Apr 2014 08:41:18 +0300")
"Michael S. Tsirkin" <mst@redhat•com> writes:
> Add tests for the new feature.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat•com>
> ---
> t/t9001-send-email.sh | 45 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 1ecdacb..97cc094 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -1334,6 +1334,51 @@ test_expect_success $PREREQ '--force sends cover letter template anyway' '
> test -n "$(ls msgtxt*)"
> '
>
> +test_cover_addresses () {
> + header="$1"
> + shift
> + clean_fake_sendmail &&
> + rm -fr outdir &&
> + git format-patch --cover-letter -2 -o outdir &&
> + cover=`echo outdir/0000-*.patch` &&
> + mv $cover cover-to-edit.patch &&
> + sed "s/^From:/$header: extra@address•com\nFrom:/" cover-to-edit.patch > $cover &&
Please do the redirection like this:
sed "s/^From:/$header: extra@address•com\nFrom:/" cover-to-edit.patch >"$cover" &&
in your later patches (I'll tweak this patch myself, so no need to
resend). We know >$cover should be the same as >"$cover", but it
was reported that some version of bash does not know it and
complains instead (see Documentation/CodingGuidelines).
next prev parent reply other threads:[~2014-04-29 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 5:41 [PATCH v4 1/2] git-send-email: two new options: to-cover, cc-cover Michael S. Tsirkin
2014-04-29 5:41 ` [PATCH v4 2/2] test/send-email: to-cover, cc-cover tests Michael S. Tsirkin
2014-04-29 19:01 ` Junio C Hamano [this message]
2014-04-29 20:05 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqppk0j6yx.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox