From: Junio C Hamano <gitster@pobox•com>
To: Dave Borowitz <dborowitz@google•com>
Cc: git@vger•kernel.org, kusmabite@gmail•com
Subject: Re: [PATCH v3 1/2] Makefile: use curl-config to determine curl flags
Date: Mon, 28 Apr 2014 14:13:38 -0700 [thread overview]
Message-ID: <xmqqppk1non1.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqtx9dp6rd.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Mon, 28 Apr 2014 12:56:54 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> This "ifeq" is redundant and will never set CURL_LIBCURL to empty
> without running the "else" part, I think. In a Makefile, a variable
> explicitly set to empty and a variable that is unset are treated the
> same....
> $ make -f Makefile CURL_CONFIG=""
> Empty Undefined
Oh, I was blind. Please ignore this noise.
Thanks.
prev parent reply other threads:[~2014-04-28 21:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 19:35 [PATCH v3 1/2] Makefile: use curl-config to determine curl flags Dave Borowitz
2014-04-28 19:35 ` [PATCH v3 2/2] Makefile: allow static linking against libcurl Dave Borowitz
2014-04-28 19:44 ` [PATCH v3 1/2] Makefile: use curl-config to determine curl flags Jonathan Nieder
2014-04-28 19:51 ` Dave Borowitz
2014-04-28 19:56 ` Junio C Hamano
2014-04-28 20:00 ` Junio C Hamano
2014-04-28 21:13 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqppk1non1.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dborowitz@google$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kusmabite@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox