public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: Ronnie Sahlberg <sahlberg@google•com>, git@vger•kernel.org
Subject: Re: [PATCH v2 2/2] commit.c: check for lock error and return early
Date: Thu, 17 Apr 2014 14:09:04 -0700	[thread overview]
Message-ID: <xmqqppkfd5ov.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <534EFEE0.9000806@alum.mit.edu> (Michael Haggerty's message of "Thu, 17 Apr 2014 00:06:24 +0200")

Michael Haggerty <mhagger@alum•mit.edu> writes:

> On 04/16/2014 08:56 PM, Ronnie Sahlberg wrote:
>> Move the check for the lock failure to happen immediately after
>> lock_any_ref_for_update().
>> Previously the lock and the check-if-lock-failed was separated by a handful
>> of string manipulation statements.
>
> Please flow sentences together into paragraphs for easier reading,
> rather than having an extremely ragged right-hand margin.
>
> The rest looks good.

Thanks, both.  I tentatively queued with the suggested log message
tweaks, and I think result reads better.

     prev parent reply	other threads:[~2014-04-17 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16 18:56 [PATCH v2 0/2] Check for lock failures early Ronnie Sahlberg
2014-04-16 18:56 ` [PATCH v2 1/2] sequencer.c: check for lock failure and bail early in fast_forward_to Ronnie Sahlberg
2014-04-16 22:03   ` Michael Haggerty
2014-04-16 18:56 ` [PATCH v2 2/2] commit.c: check for lock error and return early Ronnie Sahlberg
2014-04-16 22:06   ` Michael Haggerty
2014-04-17 21:09     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqppkfd5ov.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=mhagger@alum$(echo .)mit.edu \
    --cc=sahlberg@google$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox