Subject: Re: [PATCH v3 14/25] setup.c: convert is_git_directory() to use strbuf

From: Junio C Hamano <[email-masked]>
Date: Wed, 19 Feb 2014 12:17:32 -0800

Nguyễn Thái Ngọc Duy  <[email-masked]> writes:

> Signed-off-by: Nguyễn Thái Ngọc Duy <[email-masked]>
> ---

(Only minor nits first during this round of review)

> diff --git a/strbuf.h b/strbuf.h
> index 73e80ce..aec9fdb 100644
> --- a/strbuf.h
> +++ b/strbuf.h
> @@ -116,6 +116,10 @@ extern void strbuf_add(struct strbuf *, const void *, size_t);
>  static inline void strbuf_addstr(struct strbuf *sb, const char *s) {
>  	strbuf_add(sb, s, strlen(s));
>  }
> +static inline void strbuf_addstr_at(struct strbuf *sb, size_t len, const char *s) {

Please have the opening "{" on its own line.

Surrounding existing functions are all offenders, but that is not an
excuse to make it worse (cleaning them up will need to be done in a
separate patch).

> +	strbuf_setlen(sb, len);
> +	strbuf_add(sb, s, strlen(s));

I am not sure addstr_at() gives us a good abstraction, or at least
the name conveys what it does well not to confuse readers.

At first after only seeing its name, I would have expected that it
would splice the given string into an existing strbuf at the
location, not chopping the existing strbuf at the location and
appending.

> +}
>  static inline void strbuf_addbuf(struct strbuf *sb, const struct strbuf *sb2) {
>  	strbuf_grow(sb, sb2->len);
>  	strbuf_add(sb, sb2->buf, sb2->len);