public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Rename read_replace_refs to check_replace_refs
Date: Tue, 18 Feb 2014 13:30:54 -0800	[thread overview]
Message-ID: <xmqqppmkcdm9.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1392722695-31815-1-git-send-email-mhagger@alum.mit.edu> (Michael Haggerty's message of "Tue, 18 Feb 2014 12:24:55 +0100")

Michael Haggerty <mhagger@alum•mit.edu> writes:

> The semantics of this flag was changed in commit
>
>     e1111cef23 inline lookup_replace_object() calls
>
> but wasn't renamed at the time to minimize code churn.  Rename it now,
> and add a comment explaining its use.
>
> Signed-off-by: Michael Haggerty <mhagger@alum•mit.edu>
> ---
> This change doesn't conflict with anything in pu; perhaps we can
> squeeze it in now?

I think it is a good time to do this kind of clean-up once the
post-release dusts settle.

Thanks.

     prev parent reply	other threads:[~2014-02-18 21:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 11:24 [PATCH] Rename read_replace_refs to check_replace_refs Michael Haggerty
2014-02-18 21:30 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqppmkcdm9.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=mhagger@alum$(echo .)mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox