From: Junio C Hamano <gitster@pobox•com>
To: Christian Couder <christian.couder@gmail•com>
Cc: Karsten Blees <karsten.blees@gmail•com>,
Christian Couder <chriscool@tuxfamily•org>,
git <git@vger•kernel.org>, Jeff King <peff@peff•net>,
Joey Hess <joey@kitenet•net>,
Eric Sunshine <sunshine@sunshineco•com>
Subject: Re: [PATCH v3 07/10] builtin/replace: teach listing using short, medium or full formats
Date: Thu, 26 Dec 2013 11:10:38 -0800 [thread overview]
Message-ID: <xmqqppojctsh.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAP8UFD1hdNE__+bVtKegChBT4u3Rx7NEzBYYkdEmUwfFLLpkzg@mail.gmail.com> (Christian Couder's message of "Sat, 21 Dec 2013 10:34:06 +0100")
Christian Couder <christian.couder@gmail•com> writes:
> On Thu, Dec 19, 2013 at 7:58 PM, Junio C Hamano <gitster@pobox•com> wrote:
>> Christian Couder <christian.couder@gmail•com> writes:
>>
>>> I think this last one might be useful for people replacing objects
>>> with objects that have another type.
>>
>> ... which IIUC is strongly discouraged---didn't you have to tighten
>> it recently?
>>
>> And that makes it "useful primarily for debugging" unusual
>> situations.
>
> Ok, so would you prefer the following:
>
> - NAME_ONLY_REPLACE_FMT and "--format=name_only" instead of
> SHORT_REPLACE_FMT and "--format=short"
>
> - NAME_AND_VALUE_REPLACE_FMT and "--format=name_and_value" instead of
> MEDIUM_REPLACE_FMT and "--format=medium"
>
> - DEBUG_REPLACE_FMT and "--format=debug" instead of FULL _REPLACE_FMT
> and "--format=full"
The end-user facing names are probably fine with short, medium,
full, as long as what they show are clearly explained in the
end-user documentation (patch 10/10 covers this).
I have a hunch that we may later regret "full" when somebody wants
to add even fuller information, though. It might be better spelled
"long" instead;
I'd rather see REPLACE_FMT_ as a prefix, not suffix. Do we use
common suffix for enum values elsewhere?
next prev parent reply other threads:[~2013-12-26 19:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 7:46 [PATCH v3 00/10] teach replace objects to sha1_object_info_extended() Christian Couder
2013-12-11 7:46 ` [PATCH v3 01/10] Rename READ_SHA1_FILE_REPLACE flag to LOOKUP_REPLACE_OBJECT Christian Couder
2013-12-11 7:46 ` [PATCH v3 02/10] replace_object: don't check read_replace_refs twice Christian Couder
2013-12-11 7:46 ` [PATCH v3 03/10] Introduce lookup_replace_object_extended() to pass flags Christian Couder
2013-12-11 7:46 ` [PATCH v3 04/10] Add an "unsigned flags" parameter to sha1_object_info_extended() Christian Couder
2013-12-11 7:46 ` [PATCH v3 05/10] t6050: show that git cat-file --batch fails with replace objects Christian Couder
2013-12-11 7:46 ` [PATCH v3 06/10] sha1_file: perform object replacement in sha1_object_info_extended() Christian Couder
2013-12-11 7:46 ` [PATCH v3 07/10] builtin/replace: teach listing using short, medium or full formats Christian Couder
2013-12-18 12:37 ` Karsten Blees
2013-12-18 16:49 ` Christian Couder
2013-12-18 17:37 ` Junio C Hamano
2013-12-19 16:36 ` Christian Couder
2013-12-19 18:58 ` Junio C Hamano
2013-12-21 9:34 ` Christian Couder
2013-12-26 19:10 ` Junio C Hamano [this message]
2013-12-28 10:27 ` Christian Couder
2013-12-11 7:46 ` [PATCH v3 08/10] t6050: add tests for listing with --format Christian Couder
2013-12-11 7:46 ` [PATCH v3 09/10] builtin/replace: unset read_replace_refs Christian Couder
2013-12-11 7:46 ` [PATCH v3 10/10] Documentation/git-replace: describe --format option Christian Couder
2013-12-12 20:05 ` [PATCH v3 00/10] teach replace objects to sha1_object_info_extended() Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqppojctsh.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=joey@kitenet$(echo .)net \
--cc=karsten.blees@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox