From: Junio C Hamano <gitster@pobox•com>
To: Eugene Sajine <euguess@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: Fwd: Fwd: git-daemon access-hook race condition
Date: Thu, 12 Sep 2013 16:27:19 -0700 [thread overview]
Message-ID: <xmqqppsdmxig.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPZPVFYY6Q=zZ62mY6uGi6O7KaOO8NhUEH0YUgcQE3NBvHQEpg@mail.gmail.com> (Eugene Sajine's message of "Thu, 12 Sep 2013 19:17:08 -0400")
Eugene Sajine <euguess@gmail•com> writes:
>> So even if we feed the exit status of the service process to the
>> hook script specified by the --post-service-hook, it does not tell
>> the script if the service "succeeded" in that sense.
>
> I see what you're saying.
> In my particular use case I can work around that service status
> because even if it failed it will just trigger Jenkins to poll and in
> case of failure to transfer data there will be no new changes for
> Jenkins to work with. If we would want the --post-service-hook to know
> that data transfer succeeded or failed, then may be there should be
> some difference between "service status" and "service process status"?
> In this case the existing logic works with "service process status"
> while the --post-service-hook is fed with the "service status" (or
> name it "data transfer status")
>
> Do i make any sense?
Almost; you missed that there is no channel to pass "data transfer
status" from the service back to the daemon.
prev parent reply other threads:[~2013-09-12 23:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAPZPVFa=gqJ26iA6eQ1B6pcbTcQmmnXHYz6OQLtMORnAa5ec2w@mail.gmail.com>
2013-09-12 18:51 ` Fwd: git-daemon access-hook race condition Eugene Sajine
2013-09-12 19:15 ` Junio C Hamano
[not found] ` <CAPZPVFZLPV=JVR+SSqfX-=aLyFWZBkof+yCkivcLoKNnv6f__Q@mail.gmail.com>
2013-09-12 20:30 ` Fwd: " Eugene Sajine
2013-09-12 21:08 ` Junio C Hamano
2013-09-12 21:16 ` Eugene Sajine
2013-09-12 22:01 ` Eugene Sajine
2013-09-13 17:17 ` Eugene Sajine
2013-09-12 22:20 ` Junio C Hamano
2013-09-12 23:17 ` Eugene Sajine
2013-09-12 23:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqppsdmxig.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=euguess@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox