From: Junio C Hamano <gitster@pobox•com>
To: Sebastian Andrzej Siewior <sebastian@breakpoint•cc>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2 3/6] bswap.h: Define GIT_LITTLE_ENDIAN on msvc as little endian
Date: Thu, 12 Jun 2025 13:11:27 -0700 [thread overview]
Message-ID: <xmqqqzzod8k0.fsf@gitster.g> (raw)
In-Reply-To: <20250611221444.1567638-4-sebastian@breakpoint.cc> (Sebastian Andrzej Siewior's message of "Thu, 12 Jun 2025 00:14:39 +0200")
Sebastian Andrzej Siewior <sebastian@breakpoint•cc> writes:
> The Microsoft Visual C++ (MSVC) compiler (as of Visual Studio 2022
> version 17.13.6) does not define __BYTE_ORDER__ and its C-library does
> not define __BYTE_ORDER. The compiler is supported only an arm64 and x86
> which are all little endian.
"an arm" -> "on arm"? Just sanity checking before making local
typofix while queueing.
> Define GIT_BYTE_ORDER on msvc as little endian to avoid further checks.
>
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint•cc>
> ---
> compat/bswap.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/compat/bswap.h b/compat/bswap.h
> index 0a457542dd76a..fd604d9f7b74b 100644
> --- a/compat/bswap.h
> +++ b/compat/bswap.h
> @@ -81,6 +81,10 @@ static inline uint64_t git_bswap64(uint64_t x)
> #define bswap32(x) _byteswap_ulong(x)
> #define bswap64(x) _byteswap_uint64(x)
>
> +#define GIT_LITTLE_ENDIAN 1234
> +#define GIT_BIG_ENDIAN 4321
> +#define GIT_BYTE_ORDER GIT_LITTLE_ENDIAN
> +
> #endif
>
> #if defined(bswap32)
> @@ -122,7 +126,7 @@ static inline uint64_t git_bswap64(uint64_t x)
> # define GIT_LITTLE_ENDIAN __ORDER_LITTLE_ENDIAN__
> # define GIT_BIG_ENDIAN __ORDER_BIG_ENDIAN__
>
> -#else
> +#elif !defined(GIT_BYTE_ORDER)
>
> # define GIT_BIG_ENDIAN 4321
> # define GIT_LITTLE_ENDIAN 1234
next prev parent reply other threads:[~2025-06-12 20:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 22:14 [PATCH v2 0/6] bswap.h: Rework ntohl handling Sebastian Andrzej Siewior
2025-06-11 22:14 ` [PATCH v2 1/6] Revert "bswap.h: add support for built-in bswap functions" Sebastian Andrzej Siewior
2025-06-12 20:04 ` Junio C Hamano
2025-06-11 22:14 ` [PATCH v2 2/6] bswap.h: Add support for __BYTE_ORDER__ Sebastian Andrzej Siewior
2025-06-12 0:24 ` brian m. carlson
2025-06-12 0:43 ` Collin Funk
2025-06-12 20:10 ` Junio C Hamano
2025-06-11 22:14 ` [PATCH v2 3/6] bswap.h: Define GIT_LITTLE_ENDIAN on msvc as little endian Sebastian Andrzej Siewior
2025-06-12 20:11 ` Junio C Hamano [this message]
2025-06-11 22:14 ` [PATCH v2 4/6] bswap.h: Always overwrite ntohl/ ntohll macros Sebastian Andrzej Siewior
2025-06-12 0:14 ` brian m. carlson
2025-06-12 20:16 ` Junio C Hamano
2025-06-11 22:14 ` [PATCH v2 5/6] bswap.h: Remove optimized x86 version of bswap32/64 Sebastian Andrzej Siewior
2025-06-26 15:55 ` Kristoffer Haugsbakk
2025-07-15 19:02 ` Sebastian Andrzej Siewior
2025-06-11 22:14 ` [PATCH v2 5/6] bswap: " Sebastian Andrzej Siewior
2025-06-11 22:14 ` [PATCH v2 6/6] bswap.h: Provide a built-in based version of bswap32/64 if possible Sebastian Andrzej Siewior
2025-06-12 20:21 ` [PATCH v2 0/6] bswap.h: Rework ntohl handling Junio C Hamano
2025-07-07 22:43 ` Junio C Hamano
2025-07-09 6:04 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqqzzod8k0.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sebastian@breakpoint$(echo .)cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox