Subject: Re: [PATCH 2/2] merge-ort: fix slightly overzealous assertion for rename-to-self

From: Junio C Hamano <[email-masked]>
Date: Wed, 12 Mar 2025 16:18:39 -0700

Elijah Newren <[email-masked]> writes:

> But it might be worth mentioning that having side-effects in
> assertions is a huge no-no, and I understand that when folks have to
> debug one of those (I had to in a separate project years ago which was
> kind of nasty), that they sometimes jump to the conclusion that
> assertions are bad.

Yes, assert() invites such mistakes.  Why not avoid them when there
are better alternatives like "if (condition) BUG()"?