From: Junio C Hamano <gitster@pobox•com>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Alex Henrie <alexhenrie24@gmail•com>,
cogoni.guillaume@gmail•com, stolee@gmail•com,
git@vger•kernel.org
Subject: Re: [PATCH] mergetools: vscode: new tool
Date: Tue, 03 Sep 2024 08:56:10 -0700 [thread overview]
Message-ID: <xmqqr0a0n339.fsf@gitster.g> (raw)
In-Reply-To: <78e1d2b8-4d22-9bc9-ec5d-aaa072cbd393@gmx.de> (Johannes Schindelin's message of "Tue, 3 Sep 2024 13:11:44 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx•de> writes:
>> On Windows, VSCode adds the directory that contains code.cmd to %PATH%,
>> so there is no need to invoke mergetool_find_win32_cmd to search for the
>> program.
>
> The commit message and the patch look good to me.
Thanks, both. Let me mark the topic for 'next'.
prev parent reply other threads:[~2024-09-03 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 2:59 [PATCH] mergetools: vscode: new tool Alex Henrie
2024-09-03 11:11 ` Johannes Schindelin
2024-09-03 15:56 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr0a0n339.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=alexhenrie24@gmail$(echo .)com \
--cc=cogoni.guillaume@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=stolee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox