Subject: Re: [PATCH 14/22] shallow: fix leaking members of `struct shallow_info`

From: Junio C Hamano <[email-masked]>
Date: Thu, 29 Aug 2024 09:07:47 -0700

Toon claes <[email-masked]> writes:

>>  void clear_shallow_info(struct shallow_info *info)
>>  {
>> +	if (info->used_shallow) {
>> +		for (size_t i = 0; i < info->shallow->nr; i++)
>> +			free(info->used_shallow[i]);
>> +		free(info->used_shallow);
>> +	}
>> +
>> +	free(info->need_reachability_test);
>> +	free(info->reachable);
>> +	free(info->shallow_ref);
>>  	free(info->ours);
>>  	free(info->theirs);
>>  }
>
> `prepare_shallow_info()`, which allocates new memory. So would it be
> worth to rename this function to `release_shallow_info()`?

In the longer term in a separate "renaming everything" effort, yes.
In the context of "plug many resource leaks" series, probably no.

Thanks.