Subject: Re: [PATCH v1 1/1] pathspec: warn for a no-glob entry that contains `**`

From: Junio C Hamano <[email-masked]>
Date: Thu, 25 Mar 2021 13:09:29 -0700

Stavros Ntentos <[email-masked]> writes:

> Ofc, if someone really wanted to solve this, someone
> could rework the `void vreportf` split and auto-pad
> prefix at newline, but sounds like a project on its own ...

But when it happens, this extra "\t" would get in the way
and needs to be adjusted ;-)

It has been on the radar for quite some time to apply the same
principle for die(), error(), and warning() as how advise()
shows its "hint:" prefix.

The format strings given to these functions are end-user-facing and
subject to localization, so there is no huge compatibility issues we
need to be worried about.

The test suite have fixed expectations and such a change must be
accompanied by adjustment to the affected tests, though.