From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 0/18] snprintf cleanups
Date: Thu, 30 Mar 2017 10:24:36 -0700 [thread overview]
Message-ID: <xmqqr31e65kb.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170330062730.ycsok7skrjy5c6en@sigill.intra.peff.net> (Jeff King's message of "Thu, 30 Mar 2017 02:27:30 -0400")
Jeff King <peff@peff•net> writes:
> On Wed, Mar 29, 2017 at 09:05:33AM -0700, Junio C Hamano wrote:
>
>> > I think there are two things going on in your example.
>> >
>> > One is that obviously patch_id_addf() removes the spaces from the
>> > result. But we could do that now by keeping the big strbuf_addf(), and
>> > then just walking the result and feeding non-spaces.
>> >
>> > The second is that your addf means we are back to formatting everything
>> > into a buffer again....
>>
>> You are right to point out that I was blinded by the ugliness of
>> words stuck together without spaces in between, which was inherited
>> from the original code, and failed to see the sole point of this
>> series, which is to remove truncation without adding unnecessary
>> allocation and freeing.
>>
>> Thanks for straighten my thinking out. I think the seeming
>> ugliness, if it ever becomes a real problem, should be handled
>> outside this series after the dust settles.
>
> Yeah, the no-spaces thing should almost certainly wait.
>
> There is still the minor question of whether skipping the strbuf
> entirely is nicer, even if you still have to feed it strings without
> spaces (i.e., what I posted in my initial reply).
>
> I'm OK either with the series I posted, or wrapping up the alternative
> in a commit message.
I do find the updated one easier to follow (if anything it is more
compact); I do not think it is worth a reroll, but it is easy enough
to replace the patch part of the original with the updated patch and
tweak "it's easy to fix by moving to a strbuf" in its log message to
something like "But it's easy to eliminate the allocation with a few
helper functions, and it makes the result easier to follow", so I am
tempted to go that route myself...
next prev parent reply other threads:[~2017-03-30 17:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 19:42 [PATCH 0/18] snprintf cleanups Jeff King
2017-03-28 19:45 ` [PATCH 01/18] do not check odb_mkstemp return value for errors Jeff King
2017-03-28 19:45 ` [PATCH 02/18] odb_mkstemp: write filename into strbuf Jeff King
2017-03-28 19:45 ` [PATCH 03/18] odb_mkstemp: use git_path_buf Jeff King
2017-03-28 19:46 ` [PATCH 04/18] diff: avoid fixed-size buffer for patch-ids Jeff King
2017-03-28 19:50 ` Jeff King
2017-03-28 19:46 ` [PATCH 05/18] tag: use strbuf to format tag header Jeff King
2017-03-28 19:46 ` [PATCH 06/18] fetch: use heap buffer to format reflog Jeff King
2017-03-28 19:46 ` [PATCH 07/18] avoid using fixed PATH_MAX buffers for refs Jeff King
2017-04-17 6:00 ` Junio C Hamano
2017-04-18 3:18 ` Jeff King
2017-04-18 4:55 ` Junio C Hamano
2017-03-28 19:46 ` [PATCH 08/18] avoid using mksnpath " Jeff King
2017-03-28 19:46 ` [PATCH 09/18] create_branch: move msg setup closer to point of use Jeff King
2017-03-28 19:46 ` [PATCH 10/18] create_branch: use xstrfmt for reflog message Jeff King
2017-03-28 19:46 ` [PATCH 11/18] name-rev: replace static buffer with strbuf Jeff King
2017-03-28 19:46 ` [PATCH 12/18] receive-pack: print --pack-header directly into argv array Jeff King
2017-03-28 19:46 ` [PATCH 13/18] replace unchecked snprintf calls with heap buffers Jeff King
2017-03-28 19:46 ` [PATCH 14/18] combine-diff: replace malloc/snprintf with xstrfmt Jeff King
2017-03-28 19:46 ` [PATCH 15/18] convert unchecked snprintf into xsnprintf Jeff King
2017-03-28 19:47 ` [PATCH 16/18] transport-helper: replace checked snprintf with xsnprintf Jeff King
2017-03-28 19:47 ` [PATCH 17/18] gc: replace local buffer with git_path Jeff King
2017-03-28 19:48 ` [PATCH 18/18] daemon: use an argv_array to exec children Jeff King
2017-03-28 22:33 ` [PATCH 0/18] snprintf cleanups Junio C Hamano
2017-03-29 3:41 ` Jeff King
2017-03-29 16:05 ` Junio C Hamano
2017-03-30 6:27 ` Jeff King
2017-03-30 17:24 ` Junio C Hamano [this message]
2017-03-30 18:26 ` Jeff King
2017-03-29 7:10 ` [PATCH] Makefile: detect errors in running spatch Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr31e65kb.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox