From: Junio C Hamano <gitster@pobox•com>
To: Doug Kelly <dougk.ff7@gmail•com>
Cc: Git List <git@vger•kernel.org>,
Eric Sunshine <sunshine@sunshineco•com>,
Jeff King <peff@peff•net>
Subject: Re: [PATCH 1/2] prepare_packed_git(): refactor garbage reporting in pack directory
Date: Wed, 04 Nov 2015 11:35:52 -0800 [thread overview]
Message-ID: <xmqqr3k5a76v.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAEtYS8Q1T-ig2KqZUoCCODs1YbjOmF__vbiH5rL-s6hNaUhZeA@mail.gmail.com> (Doug Kelly's message of "Tue, 3 Nov 2015 21:12:38 -0600")
Doug Kelly <dougk.ff7@gmail•com> writes:
> I think the patches I sent (a bit prematurely) address the
> remaining comments... I did find there was a relevant test in
> t5304 already, so I added a new test in the same section (and
> cleaned up some of the garbage it wasn't removing before). I'm
> not sure if it's poor form to move tests around like this, but I
> figured it might be best to keep them logically grouped.
OK, will queue as I didn't spot anything glaringly wrong ;-)
I did wonder if we want to say anything about .bitmap files, though.
If there is one without matching .idx and .pack, shouldn't we report
just like we report .idx without .pack (or vice versa)?
Thanks.
next prev parent reply other threads:[~2015-11-04 19:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 18:41 Question: .idx without .pack causes performance issues? Doug Kelly
2015-07-21 18:57 ` Junio C Hamano
2015-07-21 19:15 ` Junio C Hamano
2015-07-21 20:48 ` Junio C Hamano
2015-07-21 21:37 ` Doug Kelly
2015-08-03 22:17 ` Doug Kelly
2015-08-04 1:27 ` Junio C Hamano
2015-08-07 21:36 ` Doug Kelly
2015-08-07 22:27 ` Junio C Hamano
2015-08-13 18:02 ` [PATCH 1/2] prepare_packed_git(): refactor garbage reporting in pack directory Doug Kelly
2015-08-13 18:02 ` [PATCH 2/2] gc: Remove garbage .idx files from pack dir Doug Kelly
2015-08-17 16:35 ` Junio C Hamano
2015-08-17 20:30 ` Junio C Hamano
2015-08-13 18:46 ` [PATCH 1/2] prepare_packed_git(): refactor garbage reporting in pack directory Eric Sunshine
2015-08-17 16:53 ` Junio C Hamano
2015-10-28 17:48 ` Junio C Hamano
2015-10-28 22:43 ` Doug Kelly
2015-11-04 3:05 ` [PATCH 1/3] " Doug Kelly
2015-11-04 3:05 ` [PATCH 2/3] t5304: Add test for cleaning pack garbage Doug Kelly
2015-11-04 3:05 ` [PATCH 3/3] gc: Remove garbage .idx files from pack dir Doug Kelly
2015-11-04 3:12 ` [PATCH 1/2] prepare_packed_git(): refactor garbage reporting in pack directory Doug Kelly
2015-11-04 19:35 ` Junio C Hamano [this message]
2015-11-04 19:56 ` Doug Kelly
2015-11-04 20:02 ` Jeff King
2015-11-04 20:08 ` Doug Kelly
2015-11-04 20:15 ` Jeff King
2015-12-30 7:37 ` Jeff King
2016-01-13 17:14 ` Doug Kelly
2016-01-13 20:08 ` Junio C Hamano
2016-01-13 20:19 ` Doug Kelly
2016-01-13 20:23 ` Jeff King
2015-11-04 19:56 ` Jeff King
[not found] ` <CABYiQpn7r2Vcf=S5RaWHBN85eBYGPV_e02+BY=4L98qfUzDT1Q@mail.gmail.com>
2015-11-11 14:58 ` Fwd: Question: .idx without .pack causes performance issues? Thomas Berg
2015-07-21 19:49 ` Doug Kelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr3k5a76v.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dougk.ff7@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox