Subject: Re: [PATCH v13 02/12] ref-filter: introduce ref_formatting_state and ref_formatting_stack

From: Junio C Hamano <[email-masked]>
Date: Mon, 24 Aug 2015 14:56:50 -0700

Karthik Nayak <[email-masked]> writes:

> +static void push_new_stack_element(struct ref_formatting_stack **stack)
> +{

Micronit.  Perhaps s/_new//;, as you do not call the other function
pop_old_stack_element().

The remainder of this step looks pretty straight-forward and was a
pleasant read.

Thanks.