From: Junio C Hamano <gitster@pobox•com>
To: "Torsten Bögershausen" <tboegi@web•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2 1/3] Push the NATIVE_CRLF Makefile variable to C and added a test for native.
Date: Mon, 25 Aug 2014 10:36:09 -0700 [thread overview]
Message-ID: <xmqqr404mpyu.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <53F83321.1060906@web.de> ("Torsten Bögershausen"'s message of "Sat, 23 Aug 2014 08:22:25 +0200")
Torsten Bögershausen <tboegi@web•de> writes:
> On 2014-08-23 00.54, Junio C Hamano wrote:
>> Torsten Bögershausen <tboegi@web•de> writes:
>>
>>> Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is
>>> incorrectly set on Mingw git. However, the Makefile variable is not
>>> propagated to the C preprocessor and results in no change. This patch
>>> pushes the definition to the C code and adds a test to validate that
>>> when core.eol as native is crlf, we actually normalize text files to this
>>> line ending convention when core.autocrlf is false.
>>>
>>> Signed-off-by: Pat Thoyts <patthoyts@users•sourceforge.net>
>>> Signed-off-by: Stepan Kasal <kasal@ucw•cz>
>>> Signed-off-by: Torsten Bögershausen <tboegi@web•de>
>>> ---
>>
>> Who should I record as the author of this patch?
>>
>
> Sorry for missing this, here is what Mingw says:
>
> commit 0caba2cacbb9d8e6a31783b45f1a13e52dec6ce8
> Author: Pat Thoyts <patthoyts@users•sourceforge.net>
> Date: Mon Nov 26 00:24:00 2012 +0000
>
> Push the NATIVE_CRLF Makefile variable to C and added a test for native.
>
> Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is
> []
When forwarding somebody else's patch, please start the *body* of
your message with the in-body header to force the author, followed
by a blank line and then the message, i.e.
From: Pat Thoyts <patthoyts@users•sourceforge.net>
Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is
incorrectly set on Mingw git. However, the Makefile variable is not...
...
The request applies to other patches in the series as well. I
suspect that using send-email on format-patch output may do the
right thing automatically.
Thanks.
prev parent reply other threads:[~2014-08-25 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 19:18 [PATCH v2 1/3] Push the NATIVE_CRLF Makefile variable to C and added a test for native Torsten Bögershausen
2014-08-22 22:54 ` Junio C Hamano
2014-08-23 6:22 ` Torsten Bögershausen
2014-08-25 17:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr404mpyu.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=tboegi@web$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox