From: Junio C Hamano <gitster@pobox•com>
To: Ronnie Sahlberg <sahlberg@google•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] enums: remove trailing ',' after last item in enum
Date: Wed, 09 Jul 2014 07:59:40 -0700 [thread overview]
Message-ID: <xmqqr41u7f37.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1404325445-17914-1-git-send-email-sahlberg@google.com> (Ronnie Sahlberg's message of "Wed, 2 Jul 2014 11:24:05 -0700")
Ronnie Sahlberg <sahlberg@google•com> writes:
> Signed-off-by: Ronnie Sahlberg <sahlberg@google•com>
> ---
Looks good; thanks.
> builtin/clean.c | 2 +-
> builtin/tag.c | 2 +-
> pretty.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/builtin/clean.c b/builtin/clean.c
> index 9a91515..27701d2 100644
> --- a/builtin/clean.c
> +++ b/builtin/clean.c
> @@ -48,7 +48,7 @@ enum color_clean {
> CLEAN_COLOR_PROMPT = 2,
> CLEAN_COLOR_HEADER = 3,
> CLEAN_COLOR_HELP = 4,
> - CLEAN_COLOR_ERROR = 5,
> + CLEAN_COLOR_ERROR = 5
> };
>
> #define MENU_OPTS_SINGLETON 01
> diff --git a/builtin/tag.c b/builtin/tag.c
> index c6e8a71..ef76556 100644
> --- a/builtin/tag.c
> +++ b/builtin/tag.c
> @@ -83,7 +83,7 @@ static int in_commit_list(const struct commit_list *want, struct commit *c)
> enum contains_result {
> CONTAINS_UNKNOWN = -1,
> CONTAINS_NO = 0,
> - CONTAINS_YES = 1,
> + CONTAINS_YES = 1
> };
>
> /*
> diff --git a/pretty.c b/pretty.c
> index 4f51287..924bc61 100644
> --- a/pretty.c
> +++ b/pretty.c
> @@ -274,7 +274,7 @@ static void add_rfc822_quoted(struct strbuf *out, const char *s, int len)
>
> enum rfc2047_type {
> RFC2047_SUBJECT,
> - RFC2047_ADDRESS,
> + RFC2047_ADDRESS
> };
>
> static int is_rfc2047_special(char ch, enum rfc2047_type type)
prev parent reply other threads:[~2014-07-09 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 18:24 [PATCH] enums: remove trailing ',' after last item in enum Ronnie Sahlberg
2014-07-02 19:58 ` Jonathan Nieder
2014-07-02 20:08 ` Ronnie Sahlberg
2014-07-09 14:59 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr41u7f37.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sahlberg@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox