Subject: Re: [PATCH] t5551: fix the 50,000 tag test

From: Junio C Hamano <[email-masked]>
Date: Mon, 09 Jun 2014 12:16:13 -0700

Torsten Bögershausen <[email-masked]> writes:

> The first version of test 23 did simply check that no output was send
> to stderr.
>
> Commit 5e2c7cd2 verified that the expected tags were actually cloned.
>
> Since the day "git clone" printed "Cloning into 'too-many-refs'" to stderr,

Thanks.  It is 68b939b2 (clone: send diagnostic messages to stderr,
2013-09-18); before it we showed the message to the standard output
stream instead.

Will queue.

> the test failed because stderr was not empty.
>
> Remove the check for stderr and make t5551-23 pass again
>
> Signed-off-by: Torsten Bögershausen <[email-masked]>
> ---
>  t/t5551-http-fetch-smart.sh | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
> index e07eaf3..2c49133 100755
> --- a/t/t5551-http-fetch-smart.sh
> +++ b/t/t5551-http-fetch-smart.sh
> @@ -240,8 +240,7 @@ test_expect_success EXPENSIVE 'create 50,000 tags in the repo' '
>  '
>  
>  test_expect_success EXPENSIVE 'clone the 50,000 tag repo to check OS command line overflow' '
> -	git clone $HTTPD_URL/smart/repo.git too-many-refs 2>err &&
> -	test_line_count = 0 err &&
> +	git clone $HTTPD_URL/smart/repo.git too-many-refs &&
>  	(
>  		cd too-many-refs &&
>  		test $(git for-each-ref refs/tags | wc -l) = 50000