public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox•com>
To: Steve Hoelzer <shoelzer@gmail•com>
Cc: git <git@vger•kernel.org>
Subject: Re: [PATCH] environment: enable core.preloadindex by default
Date: Thu, 05 Jun 2014 15:59:55 -0700	[thread overview]
Message-ID: <xmqqr433q7x0.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: CACbrTHdoA3UgoXOMVeB2ST_y-JzA2FZM7s8_uwG8C3D29WZK=Q@mail.gmail.com

Steve Hoelzer <shoelzer@gmail•com> writes:

> There is consensus that the default should change because it will
> benefit nearly all users (some just a little, but some a lot).
> See [1] and replies.
>
> [1]: http://git.661346.n2.nabble.com/git-status-takes-30-seconds-on-Windows-7-Why-tp7580816p7580853.html
>
> Signed-off-by: Steve Hoelzer <shoelzer@gmail•com>
> ---

The patch is whitespace damaged, and the log message was unusable
without referring to an external site.  Both locally fixed and
queued.

Thanks.

>  Documentation/config.txt | 4 ++--
>  environment.c            | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 1932e9b..4b3d965 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -613,9 +613,9 @@ core.preloadindex::
>  +
>  This can speed up operations like 'git diff' and 'git status' especially
>  on filesystems like NFS that have weak caching semantics and thus
> -relatively high IO latencies.  With this set to 'true', Git will do the
> +relatively high IO latencies.  When enabled, Git will do the
>  index comparison to the filesystem data in parallel, allowing
> -overlapping IO's.
> +overlapping IO's.  Defaults to true.
>
>  core.createObject::
>   You can set this to 'link', in which case a hardlink followed by
> diff --git a/environment.c b/environment.c
> index 5c4815d..1c686c9 100644
> --- a/environment.c
> +++ b/environment.c
> @@ -71,7 +71,7 @@ unsigned long pack_size_limit_cfg;
>  char comment_line_char = '#';
>
>  /* Parallel index stat data preload? */
> -int core_preload_index = 0;
> +int core_preload_index = 1;
>
>  /* This is set by setup_git_dir_gently() and/or git_default_config() */
>  char *git_work_tree_cfg;

      parent reply	other threads:[~2014-06-05 23:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02 16:43 [PATCH] environment: enable core.preloadindex by default Steve Hoelzer
2014-06-02 20:01 ` Karsten Blees
2014-06-03  6:18   ` Steve Hoelzer
2014-06-03  8:18     ` Karsten Blees
2014-06-03  8:41 ` Duy Nguyen
2014-06-05 22:59 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr433q7x0.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=shoelzer@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox