From: Junio C Hamano <gitster@pobox•com>
To: "Michael S. Tsirkin" <mst@redhat•com>
Cc: git@vger•kernel.org
Subject: Re: regression: request-pull with signed tag lacks tags/ in master
Date: Thu, 15 May 2014 12:13:18 -0700 [thread overview]
Message-ID: <xmqqr43uetyp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqzjiiev1a.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Thu, 15 May 2014 11:50:09 -0700")
Junio C Hamano <gitster@pobox•com> writes:
> "Michael S. Tsirkin" <mst@redhat•com> writes:
>
>> looks like pull requests with signed git got broken in git master:
>>
>> [mst@robin qemu]$ /usr/bin/git --version
>> git version 1.8.3.1
>> [mst@robin qemu]$ git --version
>> git version 2.0.0.rc1.18.gac53fc6.dirty
>> [mst@robin qemu]$
>> [mst@robin qemu]$ /usr/bin/git request-pull origin/master git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git for_upstream |grep git.kernel.org
>> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>>
>>
>> [mst@robin qemu]$ git request-pull origin/master git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git for_upstream |grep git.kernel.org
>> git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git for_upstream
>>
>> this for_upstream syntax is a problem because it does not work
>> for older git clients who might get this request.
>>
>> Didn't bisect yet - anyone knows what broke this?
>
> Linus ;-) The series that ends with ec44507, I think.
My reading of the earlier parts of the series is that Linus wanted
us never dwim "for-upstream" to "tags/for-upstream" or any other ref
that happens to point at the same commit as for-upstream you have.
The changes done for that purpose covered various cases a bit too
widely, and "request-pull ... tags/for_upstream" were incorrectly
stripped to a request to pull "for_upstream", which was fixed by
5aae66bd (request-pull: resurrect "pretty refname" feature,
2014-02-25).
But that fix does not resurrect the dwimming forbid by the earlier
parts of the series to turn "for_upstream" into "tags/for_upstream".
What would you get if you do this?
$ git request-pull origin/master \
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git \
tags/for_upstream | grep git.kernel.org
next prev parent reply other threads:[~2014-05-15 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 16:39 regression: request-pull with signed tag lacks tags/ in master Michael S. Tsirkin
2014-05-15 18:50 ` Junio C Hamano
2014-05-15 19:13 ` Junio C Hamano [this message]
2014-05-15 21:39 ` Michael S. Tsirkin
2014-05-15 22:13 ` Junio C Hamano
2014-05-16 16:47 ` Re* " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr43uetyp.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox