public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Shawn Pearce <spearce@spearce•org>, git <git@vger•kernel.org>
Subject: Re: No progress from push when using bitmaps
Date: Thu, 13 Mar 2014 15:23:15 -0700	[thread overview]
Message-ID: <xmqqr465hh64.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140313220754.GA20173@sigill.intra.peff.net> (Jeff King's message of "Thu, 13 Mar 2014 18:07:54 -0400")

Jeff King <peff@peff•net> writes:

> There are a few ways around this:
>
>   1. Add a new phase "Writing packs" which counts from 0 to 1. Even
>      though it's more accurate, moving from 0 to 1 really isn't that
>      useful (the throughput is, but the 0/1 just looks like noise).
>
>   2. Add a new phase "Writing reused objects" that counts from 0 bytes
>      up to N bytes. This looks stupid, though, because we are repeating
>      the current byte count both here and in the throughput.
>
>   3. Use the regular "Writing objects" progress, but fake the object
>      count. We know we are writing M bytes with N objects. Bump the
>      counter by 1 for every M/N bytes we write.
>
> The first two require some non-trivial surgery to the progress code. I
> am leaning towards the third. Not just because it's easy, but because I
> think it actually shows the most intuitive display. Yes, it's fudging
> the object numbers, but those are largely meaningless anyway (in fact,
> it makes them _better_ because now they're even, instead of getting 95%
> done and then hitting some blob that is as big as the rest of the repo
> combined).

I think the above argument, especially the "fudging but largely
meaningless anyway" part, makes perfect sense.

Thanks for looking into this.

next prev parent reply	other threads:[~2014-03-13 22:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13  0:21 No progress from push when using bitmaps Shawn Pearce
2014-03-13 21:26 ` Jeff King
2014-03-13 22:01   ` Shawn Pearce
2014-03-13 22:07     ` Jeff King
2014-03-13 22:23       ` Junio C Hamano [this message]
2014-03-13 22:24       ` Jeff King
2014-03-14  9:43       ` Michael Haggerty
2014-03-14 10:21         ` Duy Nguyen
2014-03-14 15:29           ` Jeff King
2014-03-14 23:53             ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqr465hh64.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=peff@peff$(echo .)net \
    --cc=spearce@spearce$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox