From: Junio C Hamano <gitster@pobox•com>
To: "Carlos Martín Nieto" <cmn@elego•de>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] remote: filter out invalid remote configurations
Date: Tue, 27 Aug 2013 07:50:33 -0700 [thread overview]
Message-ID: <xmqqr4dffarq.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1377608796-13732-1-git-send-email-cmn@elego.de> ("Carlos Martín Nieto"'s message of "Tue, 27 Aug 2013 15:06:36 +0200")
Carlos Martín Nieto <cmn@elego•de> writes:
> In remote's configuration callback, anything that looks like
> 'remote.<name>.*' creates a remote '<name>'. This remote may not end
> up having any configuration for a remote, but it's still in the list,
> so 'git remote' shows it, which means something like
>
> [remote "bogus"]
> hocus = pocus
>
> will show a remote 'bogus' in the listing, even though it won't work
> as a remote name for either git-fetch or git-push.
Isn't this something the user may want to be aware of, though?
Hiding these would rob a chance for such an entry to be noticed from
the user---is it a good change?
> Filter out the remotes that we created which have no urls in order to
> work around such configuration entries.
next prev parent reply other threads:[~2013-08-27 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 13:06 [PATCH] remote: filter out invalid remote configurations Carlos Martín Nieto
2013-08-27 14:50 ` Junio C Hamano [this message]
2013-08-30 12:41 ` Carlos Martín Nieto
2013-08-30 16:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr4dffarq.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=cmn@elego$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox