From: Junio C Hamano <gitster@pobox•com>
To: Elia Pinto <gitter.spiros@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v3] Makefile: add a prerequisite to the coverage-report target
Date: Wed, 13 Apr 2022 22:06:05 -0700 [thread overview]
Message-ID: <xmqqsfqg2r0i.fsf@gitster.g> (raw)
In-Reply-To: <20220414022513.31465-1-gitter.spiros@gmail.com> (Elia Pinto's message of "Thu, 14 Apr 2022 02:25:13 +0000")
Elia Pinto <gitter.spiros@gmail•com> writes:
> Directly invoking make coverage-report as a target results in an error because
> its prerequisites are missing,
>
> This patch adds the compile-test prerequisite, which is run only once each time
> the compile-report target is invoked. In practice, the developer may decide to
> review the coverage-report results without necessarily rerunning for this
> coverage-test, if it has already been run.
>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail•com>
> ---
> This is the third revision of the patch. Compared to the second:
>
> - deleted the Makefile coverage-test.file variable, replaced directly by the
> coverage-test.made file
> - added in coverage-compile as last command the touch of coverage-test.made, so
> that even if coverage-test is run first, invoking indirectly it by the first coverage-report does not
> call coverage-test and so the test suite gain.
>
> Makefile | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index f8bccfab5e..d6ae228c74 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -3407,6 +3407,7 @@ coverage-clean-results:
> $(RM) coverage-untested-functions
> $(RM) -r cover_db/
> $(RM) -r cover_db_html/
> + $(RM) coverage-test.made
>
> coverage-clean: coverage-clean-results
> $(RM) $(addsuffix *.gcno,$(object_dirs))
> @@ -3421,13 +3422,18 @@ coverage-compile:
> coverage-test: coverage-clean-results coverage-compile
> $(MAKE) CFLAGS="$(COVERAGE_CFLAGS)" LDFLAGS="$(COVERAGE_LDFLAGS)" \
> DEFAULT_TEST_TARGET=test -j1 test
> + touch coverage-test.made
> +
> +coverage-test.made:
> + @make coverage-test
s/@make/$(MAKE)/, I think.
> + touch coverage-test.made
Other than that, looking good.
Thanks.
next prev parent reply other threads:[~2022-04-14 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 2:25 [PATCH v3] Makefile: add a prerequisite to the coverage-report target Elia Pinto
2022-04-14 5:06 ` Junio C Hamano [this message]
2022-04-14 5:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsfqg2r0i.fsf@gitster.g \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitter.spiros@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox