Subject: Re: [PATCH v3 23/34] t/helper/test-touch: add helper to touch a series of files

From: Junio C Hamano <[email-masked]>
Date: Thu, 01 Jul 2021 13:00:30 -0700

"Jeff Hostetler via GitGitGadget" <[email-masked]> writes:

> diff --git a/t/helper/test-touch.c b/t/helper/test-touch.c
> new file mode 100644
> index 00000000000..e9b3b754f1f
> --- /dev/null
> +++ b/t/helper/test-touch.c
> @@ -0,0 +1,126 @@
> +/*
> + * test-touch.c: variation on /usr/bin/touch to speed up tests
> + * with a large number of files (primarily on Windows where child
> + * process are very, very expensive).
> + */
> +
> +#include "test-tool.h"
> +#include "cache.h"
> +#include "parse-options.h"
> +
> +char *seq_pattern;
> +int seq_start = 1;
> +int seq_count = 1;

With this in, "make sparse" dies like this:

    SP t/helper/test-touch.c
t/helper/test-touch.c:11:6: error: symbol 'seq_pattern' was not declared. Should it be static?
t/helper/test-touch.c:12:5: error: symbol 'seq_start' was not declared. Should it be static?
t/helper/test-touch.c:13:5: error: symbol 'seq_count' was not declared. Should it be static?