Subject: Re: [PATCH v3 02/11] merge-one-file: rewrite in C

From: Junio C Hamano <[email-masked]>
Date: Wed, 21 Oct 2020 14:20:27 -0700

Junio C Hamano <[email-masked]> writes:

>>> This open(..., ce->ce_mode) call is way insufficient.
>>> ...
> But all that is unnecessary once you port this to C.  So the comment
> does not apply to the code you wrote, I think, and should just be
> dropped.

Sorry, forgot to mention one thing.  Using ce->ce_mode to create the
output file is the way how helpers in entry.c check out paths from
the index to the working tree, so the code is OK.  It's just the
copied comment was about the issue that your code did not even have
to worry about.

Thanks.